Remove the upgradeReq property
#1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `http.IncomingMessage` object, instead of being attached to the `WebSocket` object, is passes as the second argument to the `connection` event.
3rd-Eden
approved these changes
May 11, 2017
lpinca
added a commit
that referenced
this pull request
May 16, 2017
The `http.IncomingMessage` object, instead of being attached to the `WebSocket` object, is passes as the second argument to the `connection` event.
lpinca
added a commit
that referenced
this pull request
May 16, 2017
The `http.IncomingMessage` object, instead of being attached to the `WebSocket` object, is passes as the second argument to the `connection` event.
lpinca
added a commit
that referenced
this pull request
May 17, 2017
The `http.IncomingMessage` object, instead of being attached to the `WebSocket` object, is passes as the second argument to the `connection` event.
roperzh
added a commit
to HaikuTeam/animator
that referenced
this pull request
Sep 23, 2017
In 61fa5ba the `ws` package got upgraded to v3, which comes with a breaking change to the `connect` API. This updates our consumers to the new API, fixing a crash when initializing the app. More details on `ws` v3 breaking changes [here] (websockets/ws#1104)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
upgradeReqproperty from theWebSocketobject. Thehttp.IncomingMessageobject is instead passed as the second argument to theconnectionevent.In this way most of the memory retained by the
http.IncomingMessageobject can be GC'ed reducing memory usage by ~20%.Developers can save only the required info or the whole
http.IncomingMessageobject, if they have to, when the event is emitted.See discussion in #1099.