Server socket does not close after calling .close()

[michaelmcmillan]

This test shows that the socket on the WebSocketServer does not close after calling .close().

As others have suggested, the .close() method should be an async function that accepts a callback
for when it is finished with terminating the clients and closing up the socket.

ws/lib/WebSocketServer.js

Lines 101 to 131 in 71ff077

	WebSocketServer.prototype.close = function() {
	// terminate all associated clients
	var error = null;
	try {
	for (var i = 0, l = this.clients.length; i < l; ++i) {
	this.clients[i].terminate();
	}
	}
	catch (e) {
	error = e;
	}
	// remove path descriptor, if any
	if (this.path && this._server._webSocketPaths) {
	delete this._server._webSocketPaths[this.path];
	if (Object.keys(this._server._webSocketPaths).length == 0) {
	delete this._server._webSocketPaths;
	}
	}
	// close the http server if it was internally created
	try {
	if (typeof this._closeServer !== 'undefined') {
	this._closeServer();
	}
	}
	finally {
	delete this._server;
	}
	if (error) throw error;
	}

Related issue: #31

[michaelmcmillan]

Any advice on how I can implement this? I'll happily code it myself.

[lpinca]

Hi,
I'm not sure why but the same also happens with a plain HTTP server:

'use strict';

const http = require('http');
const net = require('net');

const server = http.createServer((req, res) => {
  res.statusCode = 200;
  res.setHeader('Content-Type', 'text/plain');
  res.end('Hello World\n');
});

server.listen(3000, '0.0.0.0', () => console.log('listening on *:3000'));
server.close();

const socket = net.connect(3000, () => {
  throw new Error('connected after calling close');
});

[lpinca]

If you use

server.listen(3000, '::1', () => console.log('listening on *:3000'));

it works as expected, but if you use

server.listen(3000, '127.0.0.1', () => console.log('listening on *:3000'));

it doesn't and the connection is established.

Anyway this is not a ws issue. Feel free to file a bug in the Node.js repository.