Bug fixes for Webster entry detection

[krackers]

• Using !src by itself seems insufficient since .find always returns a valid (i.e. non-null) JS object; you must further check that it contains the relevant tag
• The match list excluded the "1913 Webster + PJC" source.

[jeffbyrnes]

@krackers thanks for this pull request!

There is one change I think that should be made to this: the “PJC” entries (or any entry with a source of three letters) is not an original Webster’s Dictionary entry, but instead the addition of a volunteer with the GCIDE Project. Here’s the relevant bit from their README that talks about source designations:

At the bottom of each paragraph in this dictionary, there is a bracketed and
tagged "source" indicated.  This tells from where the definition or other
text in that paragraph came, as follows:

[<source>1913 Webster</source>]
  =  From the original 1890 dictionary.
[<source>Webster 1913 Suppl.</source>]
  =  From the 1913 "New Words" supplement to the Webster.
[<source>WordNet 1.5</source>]
  =  From the WordNet on-line semantic network.
[<source>Century Dict. 1906.</source>]
  =  From the Century Dictionary published in 1906, especially from
          the "proper Names" supplement (volume IX).
                                     published
[<source>XXX</source>]
   = Added by one of the volunteers.

The original definitions have been tagged and in some cases reformatted or
slightly rearranged.  If substantive information is added from a second
source, usually the additional source is also noted, as in:

[<source>Webster 1913 Suppl.</source> + <source>WordNet 1.5</source>]

[krackers]

Ok I've reverted the inclusion of the PJC entries, although I still think it might be worth including them as the information added by PJC doesn't seem to be that "substantive" or alter the original too heavily. For instance,GCIDE for Aircraft gives the PJC + Webster entry

Any vehicle, such as an airplane, helicopter, balloon, etc., for floating in, or flying through, the air.

and the original webster definition (wording slightly varies depending on sources) is

A balloon, aeroplane, or other device for floating in, or flying through, the air.

Similarly GCIDE for Saltness gives the entry

Saltness (saltnĕs), n. The quality or state of being salt, or impregnated with salt; salt taste; as, “the saltness of sea water”. In the sense of having salt content, saltiness is more commonly used.

while the original webster is

The quality or state of being salt or impregnated with salt; as, the saltness of sea-water or of provisions. “The difference between saltness and bitterness. Bacon.

[jeffbyrnes]

@krackers thanks! And yes, the GCIDE volunteer entries do a great deal to expand and update the entries, we already have two built-in dictionaries in macOS that do that.

I’ve always considered the value of this dictionary is not its completeness, or up-to-dateness, but that the entries it does have are far more eloquently given, with more vibrant examples.