Update the partOfSpeech.ts file based on information from abbrevn.lst #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ooh! This is great, thanks @j-f1. The lint job is failing for unrelated reasons, but the build is good, so we’ll go ahead & ship this out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the abbreviations were obvious when I first expanded them. Some required lookup on Wiktionary. And some of them were just plain guesses. Today, I noticed that GCIDE has a handy list of all the abbreviations used in the dictionary. I went through
partOfSpeech.tsand discovered that most of the expansions were correct but some were not. This PR corrects the mistakes and marks several abbreviations which do not appear inabbrevn.lst(how helpful!) Looking over it again, I guess its just a single minor spelling change. Feel free to accept or reject!