Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pop-up text menu #555

Closed
taylornowotny opened this issue Dec 5, 2022 · 1 comment
Closed

Update pop-up text menu #555

taylornowotny opened this issue Dec 5, 2022 · 1 comment
Assignees
@TrySound
Labels
area:components Parametrized code components complexity:low Good for newcomers, up to a few days of work prio:1 The most important thing to work on

Comments

@taylornowotny
Copy link
Contributor

We are using new docs!

Here's a link to the page about this feature. Please read the whole thing before beginning to implement.
https://www.figma.com/file/xCBegXEWxROLqA1Y31z2Xo/Design-Docs?node-id=1%3A4&t=BoiiM5PaUoKXooe5-1

Notice that this component uses icon buttons, not a toggle group.
@taylornowotny taylornowotny added complexity:low Good for newcomers, up to a few days of work area:components Parametrized code components prio:1 The most important thing to work on labels Dec 5, 2022
@TrySound TrySound mentioned this issue Dec 7, 2022
Merged
12 tasks
TrySound added a commit that referenced this issue Dec 9, 2022
@TrySound
Redesign text toolbar (#567)
7637d48 
Ref #555
#107

Implemented icon button according new design,
added hover and disabled states for non-default variant.

Migrated text toolbar from toggle group to icon button.
Toggle between superscript and subscript.

<img width="285" alt="image"
src="https://user-images.githubusercontent.com/5635476/206522786-28cc6b7d-6336-4c13-8eb7-b83428598dcb.png">

<img width="315" alt="image"
src="https://user-images.githubusercontent.com/5635476/206523165-1b4a080d-0c8d-41a1-b5a9-47c197b78998.png">

<img width="197" alt="image"
src="https://user-images.githubusercontent.com/5635476/206521819-14c1fbb3-6c37-4264-8f7b-cef256b4ab23.png">
@kof
Copy link
Member

kof commented Dec 10, 2022

This is done, right?

@kof kof closed this as completed Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TrySound TrySound

Labels
area:components Parametrized code components complexity:low Good for newcomers, up to a few days of work prio:1 The most important thing to work on
Projects
No open projects
Webstudio Beta
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kof @TrySound @taylornowotny