Redesign text toolbar #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kof
reviewed
Dec 7, 2022
TrySound
force-pushed
the
text-toolbar-design
branch
from
319291c
to
8def725
Compare
kof
approved these changes
Dec 8, 2022
rpominov
reviewed
Dec 9, 2022
apps/designer/app/designer/features/workspace/canvas-tools/text-toolbar/text-toolbar.tsx
Outdated
Show resolved
Hide resolved
|
Making a release now, should we merge? |
Implemented icon button according new design, added hover and disabled states for non-default variant. Migrated text toolbar from toggle group to icon button.
TrySound
force-pushed
the
text-toolbar-design
branch
from
951a65b
to
46333a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #555 #107
Implemented icon button according new design,
added hover and disabled states for non-default variant.
Migrated text toolbar from toggle group to icon button.
Toggle between superscript and subscript.
Before requesting a review
Test cases
Before merging
.env.exampleand thedesigner/env-check.jsif mandatory