Fixed invalid int -> size_t in params #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@szabolcsbalogh - I'm not sure why the pull request (php/pecl-caching-memcache#4) refers to the NON_BLOCKING_IO_php7, but the php7 branch is much more stable. This issue fixes a segfault in 034a test. |
willfitch
changed the title
|
the php7 branch is port of master branch, which is version 2.x.x, and the branch non_blocking_io_php7 is port of non_blocking_io, which is version 3.x.x. See more about differences in #2 |
szabolcsbalogh
added a commit
that referenced
this pull request
Feb 26, 2016
Fixed invalid int -> size_t in params
|
Ok. I'll look into these warnings and tests for NON_BLOCKING_IO_php7 |
bof
added a commit
to bof/pecl-memcache
that referenced
this pull request
Feb 13, 2023
In an attempt to provoke the debug build assertion failure I saw, this is the first attempt at a test case provoking it. Doesn't work, yet... Context on the assertion failure: websupport-sk#4 0x00007fc675426c46 in __assert_fail () from /lib64/libc.so.6 websupport-sk#5 0x00007fc670cbcaf3 in zend_gc_delref (p=0x7fc670bbc000) at /opt/php/include/php/Zend/zend_types.h:1209 websupport-sk#6 0x00007fc670cbcb59 in zval_delref_p (pz=0x7ffe587973a0) at /opt/php/include/php/Zend/zend_types.h:1245 websupport-sk#7 0x00007fc670cbcc81 in zval_ptr_dtor_nogc (zval_ptr=0x7ffe587973a0) at /opt/php/include/php/Zend/zend_variables.h:34 websupport-sk#8 0x00007fc670cbdcbc in ps_read_memcache (mod_data=0x7fc674bed980 <ps_globals+96>, key=0x7fc670b81540, val=0x7ffe58797428, maxlifetime=3600) at /srv/dev/yin/phb/build/ourphp-8.1.15-debug/memcache/src/memcache_session.c:385 websupport-sk#9 0x00007fc673cd7ab3 in php_session_initialize () at /srv/dev/yin/phb/build/ourphp-8.1.15-debug/php-src/ext/session/session.c:444 websupport-sk#10 0x00007fc673cdafa3 in php_session_start () at /srv/dev/yin/phb/build/ourphp-8.1.15-debug/php-src/ext/session/session.c:1612 websupport-sk#11 0x00007fc673cded07 in zif_session_start (execute_data=0x7fc670a12d30, return_value=0x7fc670a12d10) at /srv/dev/yin/phb/build/ourphp-8.1.15-debug/php-src/ext/session/session.c:2533 websupport-sk#12 0x00007fc673feea58 in ZEND_DO_ICALL_SPEC_RETVAL_USED_HANDLER () at /srv/dev/yin/phb/build/ourphp-8.1.15-debug/php-src/Zend/zend_vm_execute.h:1297 websupport-sk#13 0x00007fc674063f3c in execute_ex (ex=0x7fc670a12930) at /srv/dev/yin/phb/build/ourphp-8.1.15-debug/php-src/Zend/zend_vm_execute.h:55779 websupport-sk#14 0x00007fc673f9a4c3 in zend_call_function (fci=0x7ffe58797990, fci_cache=0x7ffe58797970) at /srv/dev/yin/phb/build/ourphp-8.1.15-debug/php-src/Zend/zend_execute_API.c:912 websupport-sk#15 0x00007fc673f9a97d in zend_call_known_function (fn=0x7fc610866500, object=0x0, called_scope=0x0, retval_ptr=0x0, param_count=1, params=0x7ffe58797a20, named_params=0x0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This invalid typing causes a segfault on extended stats