fix: handle empty channel data #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some layers (e.g. gradient fill layers) may have empty channel data. Previously, attempting to skip over the scan lines in such channels resulted in buffer overflow (RangeError). Let's avoid this by limiting the skip amount to the size of the channel data. This ensures that empty channels cannot be "skipped" at all. Note: This appears to render the layer as a 1x1 empty image. Although this is not ideal, we can't do anything about it. Synthesizing a layer image from its gradient metadata is currently beyond our scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some layers (e.g. gradient fill layers) may have empty channel data. Previously, attempting to skip over the scan lines in such channels resulted in buffer overflow (
RangeError).Let's avoid this by limiting the skip amount to the size of the channel data. This ensures that empty channels cannot be "skipped" at all.
Note: This appears to render the layer as a 1x1 empty image. Although this is not ideal, we can't do anything about it. Synthesizing a layer image from its gradient metadata is currently beyond our scope.
Fixes #40