Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hyperx PR broke automatic window resize to fit video #17

Closed
feross opened this issue Mar 5, 2016 · 3 comments · Fixed by #18
Closed

hyperx PR broke automatic window resize to fit video #17

feross opened this issue Mar 5, 2016 · 3 comments · Fixed by #18

Comments

@feross
Copy link
Member

feross commented Mar 5, 2016

Not sure why this happened, but I bisected and found that that's the root cause.
@feross
Copy link
Member Author

feross commented Mar 5, 2016

cc @ngoldman

@ungoldman
Copy link
Contributor

weird, I'll try to fix

ungoldman added a commit that referenced this issue Mar 5, 2016
@ungoldman
fix #17 - autoresize window on play
82732aa 
function references in hyperx need to look like:

```
onloadedmetadata=${onLoadedMetadata}
```

and not:

```
onloadedmetadata="${onLoadedMetadata}"
```

also removed some unnecessary `torrent.ready` checks in the player.
@ungoldman ungoldman mentioned this issue Mar 5, 2016
Merged
@ungoldman
Copy link
Contributor

easy fix! PR --> #18

@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

autoresize window on play webtorrent/webtorrent-desktop
2 participants
@feross @ungoldman