Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for magnetURIs #54

Closed
giuscri opened this issue Mar 6, 2016 · 9 comments
Closed

Add support for magnetURIs #54

giuscri opened this issue Mar 6, 2016 · 9 comments

Comments

@giuscri
Copy link
Contributor

giuscri commented Mar 6, 2016

Some trackers make super easy to obtain magnet links compared to download the .torrent's.

Adding support for them would be very useful. (:

@ungoldman
Copy link
Contributor

Will be adding support for magnet links and URLs soon

@feross
Copy link
Member

feross commented Mar 7, 2016

There is already support for magnet links! Just paste them with Cmd+V or Ctrl+V and you're all set!

@ungoldman
Copy link
Contributor

Oh hidden feature! Might be good to add a mini dialog box to enter a URL/magnet link/info hash/file path as an option on the + button too

@feross
Copy link
Member

feross commented Mar 7, 2016

@ngoldman Yeah, we definitely need better/more UI for this, but there's already a placeholder menu option in File for adding a torrent address (will support magnet links, http/https urls, even file system urls).

And in the Edit menu, the paste option also says "Paste Torrent Address". :)

@iadj
Copy link

iadj commented Mar 8, 2016

I'd also recommend the ability to set webtorrent-app as the default app for opening magnet files on the OS.

And, while we're at it, a custom protocol i.e. wbt://<magnet> would be great!

@feross
Copy link
Member

feross commented Mar 8, 2016

@iadj I'm going to open a separate issue for your first request, since it's good: #77

Regarding the custom protocol handler, why is that desirable if WebTorrent is already set as the default handler for magnet links?

@feross
Copy link
Member

feross commented Mar 8, 2016

@ngoldman Opened an explicit issue for your request: #78

Going to close this now, since the app already supports magnet links!

@feross feross closed this as completed Mar 8, 2016
@iadj
Copy link

iadj commented Mar 8, 2016

@feross Since torrent streaming isn't supported by most popular torrent managers; developers and websites could make an integration for this without requiring users to rethink their default torrent configurations.

Websites that share torrent files generally have links such as 'Download Torrent' and 'Open Magnet'. Imagine an extra link saying 'Stream Torrent'. That's what I'd like to see.

Bonus suggestion: decide on a general torrent streaming protocol (i.e. str://<magnet>) with https://github.com/jaruba/PowderPlayer so that developers can simply add 'Stream Torrent` links that support any torrent app with the protocol!

@feross
Copy link
Member

feross commented Mar 8, 2016

@iadj Moved your suggestion to a new issue: #83

@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants