-
-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webtorrent:// protocol handler #83
Comments
+1 |
Here's some info on that: electron/packager#59 See also @jden's https://www.npmjs.com/package/register-protocol-handler (currently win32 only) |
Thanks for the mention, @ungoldman - disclaimer, that was kind of experimental and I don't know if it's actually being used anywhere currently, ymmv. |
Probably http://electron.atom.io/docs/api/protocol/ ? |
Looks like the github issue had better google juice than the atom docs, thanks for finding that Flet! That looks a lot more up to date. |
@jden @Flet @ungoldman The |
Opened an issue to ask Electron to make this easier: electron/electron#4857 |
@jden Your module is nice and simple, but it has a native dependency to link to the .NET API, and it fails to install on non-Windows platforms, obviously. I'm going to try using |
@jden Okay, here's the approach I went with: https://github.com/feross/webtorrent-app/blob/2b555e12b868b0610838e55f98a0b1d6705f49d6/main/register-protocol-handler.js#L7-L46 What do you think? If you're down, we can replace your package If not, that's fine too. I can just publish this as a separate package. |
@feross oh, nice, I was unaware of the pure registry solution. Thanks for linking to the msdn article in the comments! I'd happily take this as a patch to register-protocol-handler-windows. |
The way google brought me here from a totally unrelated search is above my comprehension.. So? Are we making a new standard protocol for streaming torrents? (we can't name it Should probably include https://github.com/mafintosh/playback in our world domination plans too. |
Playback currently uses |
@demoneaux and I have |
Imagine if there was Someone's gotta make sense of this mess at one point, creating a default protocol for streaming torrents is the proper way of doing things. |
I see value in our app-specific protocol handlers ( So, the real question is -- do we need a new protocol handler specifically for streamable torrents? We already have |
From my experience, I've seen many that prefer using uTorrent in combination with a streamer. And some users get frustrated as you can only match Whether or not a new standard protocol handler just for streaming will be embraced by web developers is the real question here. But that should not be our concern, as giving it as an option to developers can only be a good thing. |
Some options:
|
i like
|
Another option:
Has the advantage of starting with |
Upvote this comment if you prefer |
Upvote this comment if you prefer |
Upvote this comment if you prefer |
Upvote this comment if you prefer |
@jaruba Are there other developers of (legitimate) torrent streaming apps who we can ask for their opinion? Hey @mafintosh, @freeall (Playback devs) -- do you have thoughts on this? |
Maybe @Ivshti with Stremio.. If we don't include the Popcorn Time forks and friends. I can pipe more developers into this effort as they come at |
@feross I like api's that uses names as it makes it easier to understand and debug - as an example it's easier to read and understand github.com/feross than github.com/5234 (or whatever your user id might be). Btw, |
I'm fine with |
How about edit: I'm fine with |
@anonymlol |
Done Shipped in v0.8.1 |
@dcposch How is this done ? It's called stream-magnet, was that the final choice ? |
Re-opening this issue as we still haven't implemented support for the |
@JohnDoee Yep, the final name we settled on was |
I was summoned here months ago. Sorry my intertubes were clogged. In general, when referencing ipfs protocols, pls use unix path notation In this case (just from above) I think it's possible to make Either way, exciting stuff! :)
|
I am interested in support for Ace Stream. I have tried to put the hash in acestream:// URLs in a magnet link format but WebTorrent did not download anything. |
@Raulvo Please open a new issue. You posted in an old, unrelated issue. |
I'm for using so= instead, as described in the draft rfc here: Also, maybe this should be part of webtorrent instead of webtorrent-desktop? And I think a possibility to specify a file by path would also be quiet handy. |
@Daniel-Abrecht Oh, nice. This draft looks new. Let's support it and consider removing |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
Moved into it's own issue from #54 (comment)...
Since torrent streaming isn't supported by most popular torrent managers; developers and websites could make an integration for this without requiring users to rethink their default torrent configurations.
Websites that share torrent files generally have links such as 'Download Torrent' and 'Open Magnet'. Imagine an extra link saying 'Stream Torrent'. That's what I'd like to see.
Bonus suggestion: decide on a general torrent streaming protocol (i.e.
str://<magnet>
) with https://github.com/jaruba/PowderPlayer so that developers can simply add 'Stream Torrent` links that support any torrent app with the protocol!The text was updated successfully, but these errors were encountered: