Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences should save instantly #805

Closed
feross opened this issue Aug 23, 2016 · 2 comments
Closed

Preferences should save instantly #805

feross opened this issue Aug 23, 2016 · 2 comments
Assignees
Labels

Comments

@feross
Copy link
Member

feross commented Aug 23, 2016

I'm not sure what the whole state.unsaved vs. state.saved is about.

@dcposch Any ideas?

It creates weird situations where I can change a preference, quit the app without leaving the preferences page first, start the app again, preference was not saved.

Let's just do what every Mac app does and persist settings immediately when they are changed.

@feross feross added the bug label Aug 23, 2016
@feross feross self-assigned this Aug 23, 2016
@dcposch
Copy link
Contributor

dcposch commented Sep 25, 2016

Just ran into this. Pretty bad bug actually--makes it looks like the Prefs page is broken when you quit after changing settings

@dcposch
Copy link
Contributor

dcposch commented Sep 25, 2016

Fixing this will also clean up the code, because we won't have state.unsaved

@lock lock bot locked as resolved and limited conversation to collaborators Jan 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants