Toggle fullscreen on pinch to zoom #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebraminio
force-pushed
the
master
branch
6 times, most recently
from
9253a88
to
69ce07f
Compare
ebraminio
changed the title
feross
approved these changes
Mar 8, 2017
|
Thanks, looks good! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes webtorrent to do fullscreen (maximize/unmaximize) when pinch to zoom event (two finger zoom in/out gesture) happened on macOS instead probably less meaningful zoom. Have a look here for more info about the approach.
To test this, open webtorrent on mac and do two finger zoom on webtorrent window with and without this patch. The intended gesture matches VLC on pinch to zoom action.
I hope you find this useful. Thanks!