Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix playing back audio files & reading music metadata #1240

Merged
merged 24 commits into from
Apr 19, 2018
Merged

Fix playing back audio files & reading music metadata #1240

merged 24 commits into from
Apr 19, 2018

Commits on Sep 17, 2017

  1. Add audio format information to play screen. 

    Extended album information with release lebel if available.
Make use of music-metadata module (musicmetadata appears to be no longer maintained)
    @Borewit
    Borewit committed Sep 17, 2017
    Configuration menu
    Copy the full SHA
    8868128 View commit details
    Browse the repository at this point in the history

  2. Add catalognumber in addition of the release label. 

    Updated to music-metadata in order to recognize MIME-type: audio/x-flac
    @Borewit
    Borewit committed Sep 17, 2017
    Configuration menu
    Copy the full SHA
    83350b3 View commit details
    Browse the repository at this point in the history

  3. Fix lint errors

    @Borewit
    Borewit committed Sep 17, 2017
    Configuration menu
    Copy the full SHA
    6aa3a6c View commit details
    Browse the repository at this point in the history

  4. Fix max line length

    @Borewit
    Borewit committed Sep 17, 2017
    Configuration menu
    Copy the full SHA
    54e1564 View commit details
    Browse the repository at this point in the history

  5. Fix lint error

    @Borewit
    Borewit committed Sep 17, 2017
    Configuration menu
    Copy the full SHA
    52e16c3 View commit details
    Browse the repository at this point in the history

  6. Fix max line length

    @Borewit
    Borewit committed Sep 17, 2017
    Configuration menu
    Copy the full SHA
    c11a86d View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2017

  1. Eliminated mime dependency

    @Borewit
    Borewit committed Sep 20, 2017
    Configuration menu
    Copy the full SHA
    0f00985 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2018

  1. Update version of dependency music-metadata to 0.8.8

    @Borewit
    Borewit committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    f56f3c6 View commit details
    Browse the repository at this point in the history

  2. Update version of dependency music-metadata to 0.9.0

    @Borewit
    Borewit committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    30c9934 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2018

  1. Merge branch 'master' into music-metadata

    @Borewit
    Borewit committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    bc91cde View commit details
    Browse the repository at this point in the history

  2. Fix bug #1320 by update music-metadata. 

    Bug was caused by an interoperability between then-read-stream and
readable-stream.
    @Borewit
    Borewit committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    0cce110 View commit details
    Browse the repository at this point in the history

  3. Use direct file access, if the individual file has completed download… 

    …ing.

Will allow slightly faster reading of music-metadata.
    @Borewit
    Borewit committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    ba1f82f View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2018

  1. Add additional audio extensions: 'aiff', 'ape', 'mp2', 'oga', 'opus',… 

    … 'wma'
    @Borewit
    Borewit committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    d5a62cb View commit details
    Browse the repository at this point in the history

  2. Update music-metadata dependency to 0.9.2

    @Borewit
    Borewit committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    070d3ff View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2018

  1. Merge branch 'master' into music-metadata

    @Borewit
    Borewit committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    23d37d7 View commit details
    Browse the repository at this point in the history

  2. Update music-metadata dependency to 0.9.4.

    @Borewit
    Borewit committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    0572f8a View commit details
    Browse the repository at this point in the history

  3. Add comments to metadata media overlay. 

    Adjust the label element width to 120px to be able to fit in the text: 'Comments'.
Adjust the font-weight of the comments & format value to 'normal'.
    @Borewit
    Borewit committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    e5a64d9 View commit details
    Browse the repository at this point in the history

  4. Fix formatting according 'standard'

    @Borewit
    Borewit committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    a725726 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2018

  1. Update dependency music-metadata to version 0.9.5

    @Borewit
    Borewit committed Feb 24, 2018
    Configuration menu
    Copy the full SHA
    c720f65 View commit details
    Browse the repository at this point in the history

  2. Add audio metadata standalone entries for: year & release information

    @Borewit
    Borewit committed Feb 24, 2018
    Configuration menu
    Copy the full SHA
    fce0003 View commit details
    Browse the repository at this point in the history

  3. Fix audio format metadata

    @Borewit
    Borewit committed Feb 24, 2018
    Configuration menu
    Copy the full SHA
    3dcab9e View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2018

  1. Enforce music-metadata version which is able to deal with bad Ogg files

    @Borewit
    Borewit committed Mar 3, 2018
    Configuration menu
    Copy the full SHA
    34463d9 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2018

  1. Fixed the win32 version of the test-integration/test-audio: updated s… 

    …creenshots to match new meta-data.

The format value has been to partially transparent because the bit-rate is not stable.
This is due to the fact these MP3 are encoded with Variable Bit-Rate (VBR),and they are lacking a "Xing" header, providing VBR encoding details.
Related to issue #1320 & #1240.
    @Borewit
    Borewit committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    9b74602 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2018

  1. Pass file length parameter to music-metadata parser. 

    In some cases this is required to calculate the duration.
    @Borewit
    Borewit committed Mar 11, 2018
    Configuration menu
    Copy the full SHA
    bd2fbe6 View commit details
    Browse the repository at this point in the history