Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix external calls failing silently to open magnets #1367

Merged
merged 2 commits into from Apr 26, 2018

Conversation

3 participants
@codealchemist
Copy link
Contributor

commented Apr 26, 2018

Original fix from @leodutra #1168.
I reapplied it on top of current master.
When testing I found that dropping .torrent files was breaking 馃槷
So I added an additional fix to avoid trying to replace the conflicting string on torrent file objects.

@leodutra

This comment has been minimized.

Copy link

commented Apr 26, 2018

LGFM. Thank you.

@feross

feross approved these changes Apr 26, 2018

Copy link
Member

left a comment

LGTM

@feross feross merged commit 6951540 into master Apr 26, 2018

3 checks passed

Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@feross feross deleted the fix-linux-open-magnet branch Apr 26, 2018

@codealchemist codealchemist referenced this pull request Apr 26, 2018

Merged

Release/v0.20.0 #1366

@lock lock bot locked as resolved and limited conversation to collaborators Jul 25, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can鈥檛 perform that action at this time.