Add support for multiple audio tracks #1712
Conversation
|
Wow, this is a great! I haven't had a chance to look at the code or test it yet (hoping others can help review it in the meantime) but this is exciting! |
|
@hicom150 now you are a member of the webtorrent organization, you may want to create branches for PR's directly on the webtorrent repository. That makes "jumping" and operations between branches in my opinion a bit easier. |
src/renderer/pages/player-page.js
Outdated
| .then(() => { | ||
| dispatch('mediaSuccess') | ||
| }) | ||
| .catch((err) => { | ||
| if (err.name === 'NotSupportedError') { | ||
| dispatch('mediaError', 'Codec unsupported') | ||
| } | ||
| }) |
There was a problem hiding this comment.
I removed these changes using a force push on your branch
Borewit
force-pushed
the
change_audio_tracks
branch
from
5ad4f4c
to
0d27223
Compare
|
@hicom150 I stripped of the duplicate changes from #1711, with an amend commit and a force push to your branch. This will cause your local branch to be in conflict with your cloned repo branch. Rename your local branch to Please do an amend commit (maybe twice, one time with a dummy change, the second time you undo that change). Once you have done that, you can force push the branch which will put back your changes from @Borewit to @hicom150,. |
|
I think that this PR needs #1711 to be merged to work correctly in all edge cases, so I will wait just a bit 😅 |
Makes sense, let's get #1711 in |
|
Very nice @hicom150, I am glad these improvements are in. |
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[x] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Enabling Chromium
experimentalFeaturesI made an attempt to add support for changing between multiple audio tracks.Is there anything you'd like reviewers to focus on?
As it need to enable
experimentalFeatures, check that all other features work as expected 😅