Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update music metadata 6.1.0 #1772

Merged
merged 5 commits into from
Jan 8, 2020
Merged

Update music metadata 6.1.0 #1772

merged 5 commits into from
Jan 8, 2020

Conversation

Borewit
Copy link
Member

@Borewit Borewit commented Jan 6, 2020 •
edited

Update dependency to music-metadata v6.1.0

Changes:

  1. Update call to parseStream with IFileInfo, to adopt to music-metadata v6 API
  2. If the parsing of the file (or torrent stream) has completed, send a final update event with metadata.
  3. Renamed promise onMetaData to onMetadata
  4. Add additional audio extensions (which mostly helps to determine if torrent is audio torrent):
extension Description
.m2a MPEG-1 Layer 2 Audio File
.mka Matroska audio
.mpc Musepack
.wv WavePack

This was referenced Jan 6, 2020
Closed
Closed
@Borewit Borewit self-assigned this Jan 6, 2020
hicom150
hicom150 approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@hicom150 hicom150 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

🎉 Awesome work @Borewit 🎉

@Borewit Borewit force-pushed the greenkeeper/music-metadata-6.1.0 branch from ef29ff2 to 38aef81 Compare January 8, 2020 18:59
@Borewit Borewit merged commit 6f2aa86 into master Jan 8, 2020
@Borewit Borewit deleted the greenkeeper/music-metadata-6.1.0 branch January 8, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hicom150 hicom150 hicom150 approved these changes

@codealchemist codealchemist Awaiting requested review from codealchemist

Assignees

@Borewit Borewit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Borewit @hicom150