Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

play first video file #727

Closed
wants to merge 1 commit into from
Closed

play first video file #727

wants to merge 1 commit into from

Conversation

anonymlol
Copy link
Contributor

The files inside a torrent are usually sorted, so I believe playing the first file as default makes more sense than playing the biggest.

@mathiasvr
Copy link
Contributor

mathiasvr commented Jul 19, 2016

Yes when there are multiple video files this is often desirable, but maybe we should select the biggest file if one is considerably larger than the others, or if there are only 1 or 2 playable files?

@anonymlol
Copy link
Contributor Author

anonymlol commented Jul 19, 2016

I think we should stick to the file order inside the torrent by default. People usually sort their files inside a torrent by naming them appropriately ("file 01", "file 02", etc.), so choosing by file size could play things out of order.

Playing something other than the first file should be set by a specific parameter. There was a discussion about this here. Maybe we should open a new issue to talk about this parameter since the old one was closed.

@mathiasvr
Copy link
Contributor

Selecting an index is still only a proposal for the proposed 'stream+magnet' protocol and will not work with normal magnet or torrent links. I was thinking that selecting the first file would be a problem for torrents that contains only the main video and a sample, but it seems that the main content is usually ordered first, so this PR is probably fine 👍

@anonymlol anonymlol mentioned this pull request Jul 30, 2016
@anonymlol anonymlol closed this Jul 30, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants