Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Deprecate webtorrent-hybrid #195

Merged
merged 6 commits into from
Jun 2, 2024
Merged

Conversation

SilentBot1
Copy link
Member

@SilentBot1 SilentBot1 commented Jun 2, 2024

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain:

What changes did you make? (Give an overview)

As of WebTorrent >= 2.3.0 WebRTC support has been added to the WebTorrent package via webrtc-polyfill and node-datachannel, removing the need for webtorrent-hybrid.

Which issue (if any) does this pull request address?

Is there anything you'd like reviewers to focus on?

This package is deprecated as of WebTorrent >= 2.3.0 as native WebRTC support has been added to WebTorrent. Please switch to using the "webtorrent" package.
Copy link

welcome bot commented Jun 2, 2024

🙌 Thanks for opening this pull request! You're awesome.

Copy link

socket-security bot commented Jun 2, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/create-torrent@6.0.17 filesystem +12 153 kB webtorrent-bot
npm/webtorrent@2.3.2 Transitive: environment, filesystem, network +92 5.09 MB

🚮 Removed packages: npm/wrtc@0.4.7

View full report↗︎

README.md Outdated Show resolved Hide resolved
SilentBot1 and others added 3 commits June 2, 2024 15:21
Update `Deprecated Warning` to `Deprecation Warning`

Co-authored-by: Cas_ <6506529+ThaUnknown@users.noreply.github.com>
…ackers to magnetURIs which do not already have them.
package.json Outdated Show resolved Hide resolved
Copy link
Member

@ThaUnknown ThaUnknown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SilentBot1 SilentBot1 marked this pull request as ready for review June 2, 2024 14:36
@SilentBot1 SilentBot1 merged commit fe511bf into master Jun 2, 2024
4 checks passed
@SilentBot1 SilentBot1 deleted the deprecate branch June 2, 2024 14:37
Copy link

welcome bot commented Jun 2, 2024

🎉 Congrats on getting your first pull request landed!

webtorrent-bot pushed a commit that referenced this pull request Jun 2, 2024
# [6.0.0](v5.0.2...v6.0.0) (2024-06-02)

* BREAKING CHANGE: Deprecate webtorrent-hybrid (#195) ([fe511bf](fe511bf)), closes [#195](#195)

### BREAKING CHANGES

* Deprecate webtorrent-hybrid

This package is deprecated as of WebTorrent >= 2.3.0 as native WebRTC support has been added to WebTorrent. Please switch to using the "webtorrent" package.

* fix: Update ci to use NodeJS 16 to match package.json

* Update README.md

Update `Deprecated Warning` to `Deprecation Warning`

Co-authored-by: Cas_ <6506529+ThaUnknown@users.noreply.github.com>

* fix: re-add WEBTORRENT_ANNOUNCE which is used for adding websocket trackers to magnetURIs which do not already have them.

* feat: update webtorrent-cli to v5
@webtorrent-bot
Copy link

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants