refactor: replace deprecated String.prototype.substr() #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
|
🙌 Thanks for opening this pull request! You're awesome. |
DiegoRBaquero
approved these changes
Mar 24, 2022
|
🎉 Congrats on getting your first pull request landed! |
|
Thank you <3 |
|
🎉 This PR is included in version 1.8.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
DiegoRBaquero
added a commit
that referenced
this pull request
Jul 3, 2022
* fix: getStreamURL docs (#2257) * chore(release): 1.7.4 ## [1.7.4](v1.7.3...v1.7.4) (2022-02-03) ### Bug Fixes * getStreamURL docs ([#2257](#2257)) ([69bdd93](69bdd93)) * feat: 1.8.0 fixing * chore(release): 1.8.0 # [1.8.0](v1.7.4...v1.8.0) (2022-02-03) ### Features * 1.8.0 fixing ([cac563b](cac563b)) * fix: going for 1.8.1 * chore(release): 1.8.1 ## [1.8.1](v1.8.0...v1.8.1) (2022-02-03) ### Bug Fixes * going for 1.8.1 ([e39057f](e39057f)) * chore(deps): update dependency tape to v5.5.1 * chore(deps): update dependency tape to v5.5.2 * chore(docs): Remove duplicate config row (#2265) * fix(deps): update dependency simple-peer to ^9.11.1 * chore(release): 1.8.2 ## [1.8.2](v1.8.1...v1.8.2) (2022-02-17) ### Bug Fixes * **deps:** update dependency simple-peer to ^9.11.1 ([34df41a](34df41a)) * docs: Added TorQuiX docker webclient, to faq.md (#2262) * Added TorQuiX docker webclient * docs: Added TorQuiX docker webclient, to faq.md Co-authored-by: Mauro Mazzocchetti <m.mazzocchetti@tech4care.it> * chore(release): 1.8.3 ## [1.8.3](v1.8.2...v1.8.3) (2022-02-21) * fix(deps): update dependency torrent-discovery to ^9.4.8 (#2272) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(release): 1.8.4 ## [1.8.4](v1.8.3...v1.8.4) (2022-03-03) ### Bug Fixes * **deps:** update dependency torrent-discovery to ^9.4.8 ([#2272](#2272)) ([aa2fa59](aa2fa59)) * chore(deps): update actions/stale action to v5 (#2271) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update actions/setup-node action to v3 (#2268) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update actions/checkout action to v3 (#2270) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update dependency bittorrent-tracker to v9.18.4 * fix(deps): update dependency torrent-discovery to ^9.4.9 * chore(release): 1.8.5 ## [1.8.5](v1.8.4...v1.8.5) (2022-03-06) ### Bug Fixes * **deps:** update dependency torrent-discovery to ^9.4.9 ([5a08647](5a08647)) * fix(deps): update dependency create-torrent to ^5.0.2 (#2276) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(release): 1.8.6 ## [1.8.6](v1.8.5...v1.8.6) (2022-03-11) ### Bug Fixes * **deps:** update dependency create-torrent to ^5.0.2 ([#2276](#2276)) ([f389f87](f389f87)) * chore(deps): update actions/cache action to v3 (#2281) * chore(deps): update actions/cache action to v3 * Update release.yml Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Diego Rodríguez Baquero <diego@mothership.com> * refactor: replace deprecated String.prototype.substr() (#2282) .substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated Signed-off-by: Tobias Speicher <rootcommander@gmail.com> * chore(deps): update dependency finalhandler to v1.2.0 (#2283) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(release): 1.8.7 ## [1.8.7](v1.8.6...v1.8.7) (2022-03-24) * fix(deps): update dependency debug to ^4.3.4 * chore(release): 1.8.8 ## [1.8.8](v1.8.7...v1.8.8) (2022-03-25) ### Bug Fixes * **deps:** update dependency debug to ^4.3.4 ([017c488](017c488)) * chore(deps): update webtorrent * fix(deps): update dependency parse-torrent to ^9.1.5 * chore(release): 1.8.9 ## [1.8.9](v1.8.8...v1.8.9) (2022-03-26) ### Bug Fixes * **deps:** update dependency parse-torrent to ^9.1.5 ([650a8c9](650a8c9)) * chore(deps): update dependency serve-static to v1.15.0 (#2285) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix: web seed request URLs (#2267) * fix: web seed request URLs When adding a multi torrent file (not magnet link) which has only web seeds, the torrent fails to download because webtorrent seems to try to call the wrong URL. Suppose that we are using the default download path of `/tmp/webtorrent`, and we have a web seed at `https://some-s3-bucket.s3.amazonaws.com/my-torrent` where `my-torrent` contains some nested directory structure like this: ``` my-torrent/ file1.txt file2/ file2.txt ``` Webtorrent will attempt to fetch the following URLs: ``` https://some-s3-bucket.s3.amazonaws.com/my-torrent//tmp/webtorrent/my-torrent/file1.txt https://some-s3-bucket.s3.amazonaws.com/my-torrent//tmp/webtorrent/my-torrent/file2/file2.txt ``` This is obviously incorrect, but perhaps I'm doing something wrong to cause this. I dug through the code, and it seems that `fs-chunk-store` is [modifying `file.path`](https://github.com/webtorrent/fs-chunk-store/blob/master/index.js#L48) when the [chunk store is created](https://github.com/webtorrent/webtorrent/blob/master/lib/torrent.js#L485). Stripping off the temp path fixes this issue and the download progresses as expected. * Update lib/webconn.js Co-authored-by: Diego Rodríguez Baquero <github@diegorbaquero.com> Co-authored-by: Diego Rodríguez Baquero <github@diegorbaquero.com> * chore(release): 1.8.10 ## [1.8.10](v1.8.9...v1.8.10) (2022-03-27) ### Bug Fixes * web seed request URLs ([#2267](#2267)) ([5b4880a](5b4880a)) * refactor: trigger _onWireWithMetadata after selections are updated (#2103) Co-authored-by: Diego Rodríguez Baquero <github@diegorbaquero.com> * chore(release): 1.8.11 ## [1.8.11](v1.8.10...v1.8.11) (2022-03-27) * fix(deps): update dependency bittorrent-protocol to ^3.5.2 * chore(release): 1.8.12 ## [1.8.12](v1.8.11...v1.8.12) (2022-03-28) ### Bug Fixes * **deps:** update dependency bittorrent-protocol to ^3.5.2 ([13fb0d6](13fb0d6)) * chore: add locking of threads [skip ci] * fix(deps): update dependency fs-chunk-store to ^2.0.5 * chore(release): 1.8.13 ## [1.8.13](v1.8.12...v1.8.13) (2022-03-30) ### Bug Fixes * **deps:** update dependency fs-chunk-store to ^2.0.5 ([2eef418](2eef418)) * chore: every day * ci: fix failing ci * chore(deps): update dependency tape to v5.5.3 * chore: standard 17 * fix(deps): update dependency bittorrent-protocol to ^3.5.3 (#2302) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix(deps): update dependency bitfield to ^4.1.0 (#2303) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(release): 1.8.14 ## [1.8.14](v1.8.13...v1.8.14) (2022-04-22) ### Bug Fixes * **deps:** update dependency bitfield to ^4.1.0 ([#2303](#2303)) ([a778522](a778522)) * **deps:** update dependency bittorrent-protocol to ^3.5.3 ([#2302](#2302)) ([11f9426](11f9426)) * docs: replace `git.io` link with the actual URL (#2305) * chore(release): 1.8.15 ## [1.8.15](v1.8.14...v1.8.15) (2022-04-26) * fix(deps): update dependency bittorrent-protocol to ^3.5.5 * chore(release): 1.8.16 ## [1.8.16](v1.8.15...v1.8.16) (2022-04-28) ### Bug Fixes * **deps:** update dependency bittorrent-protocol to ^3.5.5 ([3522080](3522080)) * chore(docs): add miru, haven torrent client (#2312) * chore(deps): update dependency babel-minify to v0.5.2 (#2313) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update github/codeql-action action to v2 (#2304) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix: measure transfer rates without using timeouts (#2314) * chore(release): 1.8.17 ## [1.8.17](v1.8.16...v1.8.17) (2022-05-11) ### Bug Fixes * measure transfer rates without using timeouts ([#2314](#2314)) ([522ee4c](522ee4c)) * fix(deps): update dependency bittorrent-tracker to v9.18.6 (#2315) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(release): 1.8.18 ## [1.8.18](v1.8.17...v1.8.18) (2022-05-11) ### Bug Fixes * **deps:** update dependency bittorrent-tracker to v9.18.6 ([#2315](#2315)) ([b63d652](b63d652)) * docs: Updated TorQuiX with new name CrawFish and updated link reference, to faq.md (#2316) [skip ci] * Added TorQuiX docker webclient * docs: Added TorQuiX docker webclient, to faq.md * docs: Updated TorQuiX with new name CrawFish and updated link reference, to faq.md Co-authored-by: Mauro Mazzocchetti <m.mazzocchetti@tech4care.it> * chore(docs): add Niwder cloud torrent platform (#2317) [skip ci] Co-authored-by: Diego Rodríguez Baquero <github@diegorbaquero.com> * fix(deps): update dependency torrent-discovery to ^9.4.12 * chore(release): 1.8.19 ## [1.8.19](v1.8.18...v1.8.19) (2022-05-11) ### Bug Fixes * **deps:** update dependency torrent-discovery to ^9.4.12 ([36e931a](36e931a)) * fix(deps): update dependency bittorrent-dht to ^10.0.3 (#2320) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(release): 1.8.20 ## [1.8.20](v1.8.19...v1.8.20) (2022-05-14) ### Bug Fixes * **deps:** update dependency bittorrent-dht to ^10.0.3 ([#2320](#2320)) ([2ebbd8e](2ebbd8e)) * fix(deps): update dependency throughput to ^1.0.1 (#2321) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(release): 1.8.21 ## [1.8.21](v1.8.20...v1.8.21) (2022-05-23) ### Bug Fixes * **deps:** update dependency throughput to ^1.0.1 ([#2321](#2321)) ([d53d95e](d53d95e)) * fix(deps): update dependency bittorrent-dht to ^10.0.4 * chore(release): 1.8.22 ## [1.8.22](v1.8.21...v1.8.22) (2022-05-24) ### Bug Fixes * **deps:** update dependency bittorrent-dht to ^10.0.4 ([327d723](327d723)) * chore(deps): update dependency bittorrent-tracker to v9.19.0 * chore(deps): update dependency semantic-release to v19.0.3 [security] * sponsor * fix(deps): update dependency torrent-discovery to ^9.4.13 * chore(release): 1.8.23 ## [1.8.23](v1.8.22...v1.8.23) (2022-06-23) ### Bug Fixes * **deps:** update dependency torrent-discovery to ^9.4.13 ([1e3373a](1e3373a)) * fix: support stream cancelling (#2335) * chore(release): 1.8.24 ## [1.8.24](v1.8.23...v1.8.24) (2022-06-23) ### Bug Fixes * support stream cancelling ([#2335](#2335)) ([2e4f91f](2e4f91f)) Co-authored-by: Cas <6506529+ThaUnknown@users.noreply.github.com> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> Co-authored-by: Diego Rodríguez Baquero <diego@mothership.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Artak Safaryan <32634773+holoyan@users.noreply.github.com> Co-authored-by: Drakonkat <adamo.mazzocchetti@gmail.com> Co-authored-by: Mauro Mazzocchetti <m.mazzocchetti@tech4care.it> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: CommanderRoot <CommanderRoot@users.noreply.github.com> Co-authored-by: Justin Lewis Salmon <jlsalmon@users.noreply.github.com> Co-authored-by: Alex <alxmorais8@msn.com> Co-authored-by: Sukka <isukkaw@gmail.com> Co-authored-by: Nipuna Weerasekara <w.nipuna@gmail.com> Co-authored-by: Feross Aboukhadijeh <feross@feross.org>
DiegoRBaquero
added a commit
that referenced
this pull request
Nov 10, 2022
* fix: getStreamURL docs (#2257) * chore(release): 1.7.4 ## [1.7.4](v1.7.3...v1.7.4) (2022-02-03) ### Bug Fixes * getStreamURL docs ([#2257](#2257)) ([69bdd93](69bdd93)) * feat: 1.8.0 fixing * chore(release): 1.8.0 # [1.8.0](v1.7.4...v1.8.0) (2022-02-03) ### Features * 1.8.0 fixing ([cac563b](cac563b)) * fix: going for 1.8.1 * chore(release): 1.8.1 ## [1.8.1](v1.8.0...v1.8.1) (2022-02-03) ### Bug Fixes * going for 1.8.1 ([e39057f](e39057f)) * chore(deps): update dependency tape to v5.5.1 * chore(deps): update dependency tape to v5.5.2 * chore(docs): Remove duplicate config row (#2265) * fix(deps): update dependency simple-peer to ^9.11.1 * chore(release): 1.8.2 ## [1.8.2](v1.8.1...v1.8.2) (2022-02-17) ### Bug Fixes * **deps:** update dependency simple-peer to ^9.11.1 ([34df41a](34df41a)) * docs: Added TorQuiX docker webclient, to faq.md (#2262) * Added TorQuiX docker webclient * docs: Added TorQuiX docker webclient, to faq.md Co-authored-by: Mauro Mazzocchetti <m.mazzocchetti@tech4care.it> * chore(release): 1.8.3 ## [1.8.3](v1.8.2...v1.8.3) (2022-02-21) * fix(deps): update dependency torrent-discovery to ^9.4.8 (#2272) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(release): 1.8.4 ## [1.8.4](v1.8.3...v1.8.4) (2022-03-03) ### Bug Fixes * **deps:** update dependency torrent-discovery to ^9.4.8 ([#2272](#2272)) ([aa2fa59](aa2fa59)) * chore(deps): update actions/stale action to v5 (#2271) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update actions/setup-node action to v3 (#2268) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update actions/checkout action to v3 (#2270) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update dependency bittorrent-tracker to v9.18.4 * fix(deps): update dependency torrent-discovery to ^9.4.9 * chore(release): 1.8.5 ## [1.8.5](v1.8.4...v1.8.5) (2022-03-06) ### Bug Fixes * **deps:** update dependency torrent-discovery to ^9.4.9 ([5a08647](5a08647)) * fix(deps): update dependency create-torrent to ^5.0.2 (#2276) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(release): 1.8.6 ## [1.8.6](v1.8.5...v1.8.6) (2022-03-11) ### Bug Fixes * **deps:** update dependency create-torrent to ^5.0.2 ([#2276](#2276)) ([f389f87](f389f87)) * chore(deps): update actions/cache action to v3 (#2281) * chore(deps): update actions/cache action to v3 * Update release.yml Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Diego Rodríguez Baquero <diego@mothership.com> * refactor: replace deprecated String.prototype.substr() (#2282) .substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated Signed-off-by: Tobias Speicher <rootcommander@gmail.com> * chore(deps): update dependency finalhandler to v1.2.0 (#2283) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(release): 1.8.7 ## [1.8.7](v1.8.6...v1.8.7) (2022-03-24) * fix(deps): update dependency debug to ^4.3.4 * chore(release): 1.8.8 ## [1.8.8](v1.8.7...v1.8.8) (2022-03-25) ### Bug Fixes * **deps:** update dependency debug to ^4.3.4 ([017c488](017c488)) * chore(deps): update webtorrent * fix(deps): update dependency parse-torrent to ^9.1.5 * chore(release): 1.8.9 ## [1.8.9](v1.8.8...v1.8.9) (2022-03-26) ### Bug Fixes * **deps:** update dependency parse-torrent to ^9.1.5 ([650a8c9](650a8c9)) * chore(deps): update dependency serve-static to v1.15.0 (#2285) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix: web seed request URLs (#2267) * fix: web seed request URLs When adding a multi torrent file (not magnet link) which has only web seeds, the torrent fails to download because webtorrent seems to try to call the wrong URL. Suppose that we are using the default download path of `/tmp/webtorrent`, and we have a web seed at `https://some-s3-bucket.s3.amazonaws.com/my-torrent` where `my-torrent` contains some nested directory structure like this: ``` my-torrent/ file1.txt file2/ file2.txt ``` Webtorrent will attempt to fetch the following URLs: ``` https://some-s3-bucket.s3.amazonaws.com/my-torrent//tmp/webtorrent/my-torrent/file1.txt https://some-s3-bucket.s3.amazonaws.com/my-torrent//tmp/webtorrent/my-torrent/file2/file2.txt ``` This is obviously incorrect, but perhaps I'm doing something wrong to cause this. I dug through the code, and it seems that `fs-chunk-store` is [modifying `file.path`](https://github.com/webtorrent/fs-chunk-store/blob/master/index.js#L48) when the [chunk store is created](https://github.com/webtorrent/webtorrent/blob/master/lib/torrent.js#L485). Stripping off the temp path fixes this issue and the download progresses as expected. * Update lib/webconn.js Co-authored-by: Diego Rodríguez Baquero <github@diegorbaquero.com> Co-authored-by: Diego Rodríguez Baquero <github@diegorbaquero.com> * chore(release): 1.8.10 ## [1.8.10](v1.8.9...v1.8.10) (2022-03-27) ### Bug Fixes * web seed request URLs ([#2267](#2267)) ([5b4880a](5b4880a)) * refactor: trigger _onWireWithMetadata after selections are updated (#2103) Co-authored-by: Diego Rodríguez Baquero <github@diegorbaquero.com> * chore(release): 1.8.11 ## [1.8.11](v1.8.10...v1.8.11) (2022-03-27) * fix(deps): update dependency bittorrent-protocol to ^3.5.2 * chore(release): 1.8.12 ## [1.8.12](v1.8.11...v1.8.12) (2022-03-28) ### Bug Fixes * **deps:** update dependency bittorrent-protocol to ^3.5.2 ([13fb0d6](13fb0d6)) * chore: add locking of threads [skip ci] * fix(deps): update dependency fs-chunk-store to ^2.0.5 * chore(release): 1.8.13 ## [1.8.13](v1.8.12...v1.8.13) (2022-03-30) ### Bug Fixes * **deps:** update dependency fs-chunk-store to ^2.0.5 ([2eef418](2eef418)) * chore: every day * ci: fix failing ci * chore(deps): update dependency tape to v5.5.3 * chore: standard 17 * fix(deps): update dependency bittorrent-protocol to ^3.5.3 (#2302) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix(deps): update dependency bitfield to ^4.1.0 (#2303) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(release): 1.8.14 ## [1.8.14](v1.8.13...v1.8.14) (2022-04-22) ### Bug Fixes * **deps:** update dependency bitfield to ^4.1.0 ([#2303](#2303)) ([a778522](a778522)) * **deps:** update dependency bittorrent-protocol to ^3.5.3 ([#2302](#2302)) ([11f9426](11f9426)) * docs: replace `git.io` link with the actual URL (#2305) * chore(release): 1.8.15 ## [1.8.15](v1.8.14...v1.8.15) (2022-04-26) * fix(deps): update dependency bittorrent-protocol to ^3.5.5 * chore(release): 1.8.16 ## [1.8.16](v1.8.15...v1.8.16) (2022-04-28) ### Bug Fixes * **deps:** update dependency bittorrent-protocol to ^3.5.5 ([3522080](3522080)) * chore(docs): add miru, haven torrent client (#2312) * chore(deps): update dependency babel-minify to v0.5.2 (#2313) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update github/codeql-action action to v2 (#2304) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix: measure transfer rates without using timeouts (#2314) * chore(release): 1.8.17 ## [1.8.17](v1.8.16...v1.8.17) (2022-05-11) ### Bug Fixes * measure transfer rates without using timeouts ([#2314](#2314)) ([522ee4c](522ee4c)) * fix(deps): update dependency bittorrent-tracker to v9.18.6 (#2315) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(release): 1.8.18 ## [1.8.18](v1.8.17...v1.8.18) (2022-05-11) ### Bug Fixes * **deps:** update dependency bittorrent-tracker to v9.18.6 ([#2315](#2315)) ([b63d652](b63d652)) * docs: Updated TorQuiX with new name CrawFish and updated link reference, to faq.md (#2316) [skip ci] * Added TorQuiX docker webclient * docs: Added TorQuiX docker webclient, to faq.md * docs: Updated TorQuiX with new name CrawFish and updated link reference, to faq.md Co-authored-by: Mauro Mazzocchetti <m.mazzocchetti@tech4care.it> * chore(docs): add Niwder cloud torrent platform (#2317) [skip ci] Co-authored-by: Diego Rodríguez Baquero <github@diegorbaquero.com> * fix(deps): update dependency torrent-discovery to ^9.4.12 * chore(release): 1.8.19 ## [1.8.19](v1.8.18...v1.8.19) (2022-05-11) ### Bug Fixes * **deps:** update dependency torrent-discovery to ^9.4.12 ([36e931a](36e931a)) * fix(deps): update dependency bittorrent-dht to ^10.0.3 (#2320) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(release): 1.8.20 ## [1.8.20](v1.8.19...v1.8.20) (2022-05-14) ### Bug Fixes * **deps:** update dependency bittorrent-dht to ^10.0.3 ([#2320](#2320)) ([2ebbd8e](2ebbd8e)) * fix(deps): update dependency throughput to ^1.0.1 (#2321) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(release): 1.8.21 ## [1.8.21](v1.8.20...v1.8.21) (2022-05-23) ### Bug Fixes * **deps:** update dependency throughput to ^1.0.1 ([#2321](#2321)) ([d53d95e](d53d95e)) * fix(deps): update dependency bittorrent-dht to ^10.0.4 * chore(release): 1.8.22 ## [1.8.22](v1.8.21...v1.8.22) (2022-05-24) ### Bug Fixes * **deps:** update dependency bittorrent-dht to ^10.0.4 ([327d723](327d723)) * chore(deps): update dependency bittorrent-tracker to v9.19.0 * chore(deps): update dependency semantic-release to v19.0.3 [security] * sponsor * fix(deps): update dependency torrent-discovery to ^9.4.13 * chore(release): 1.8.23 ## [1.8.23](v1.8.22...v1.8.23) (2022-06-23) ### Bug Fixes * **deps:** update dependency torrent-discovery to ^9.4.13 ([1e3373a](1e3373a)) * fix: support stream cancelling (#2335) * chore(release): 1.8.24 ## [1.8.24](v1.8.23...v1.8.24) (2022-06-23) ### Bug Fixes * support stream cancelling ([#2335](#2335)) ([2e4f91f](2e4f91f)) * fix: use streamx instead of stream * fix: null opts causing error * fix(deps): update dependency create-torrent to ^5.0.3 * chore(release): 1.8.25 ## [1.8.25](v1.8.24...v1.8.25) (2022-07-03) ### Bug Fixes * **deps:** update dependency create-torrent to ^5.0.3 ([5009d10](5009d10)) * fix: dedupe packages * fix(deps): update dependency create-torrent to ^5.0.4 * chore(release): 1.8.26 ## [1.8.26](v1.8.25...v1.8.26) (2022-07-04) ### Bug Fixes * **deps:** update dependency create-torrent to ^5.0.4 ([3728336](3728336)) * fix: drop multi-stream * chore: update dep * chore: update deps * chore(deps): update dependency tape to v5.6.0 * chore(deps): update dependency semantic-release to v19.0.5 * fix(deps): update dependency fast-blob-stream to ^1.1.1 * fix(deps): update dependency join-async-iterator to ^1.1.1 * chore(release): 1.8.27 ## [1.8.27](v1.8.26...v1.8.27) (2022-09-02) ### Bug Fixes * dedupe packages ([9ea33c2](9ea33c2)) * drop multi-stream ([5d87d1b](5d87d1b)) * null opts causing error ([3a8f901](3a8f901)) * use streamx instead of stream ([8b97ee8](8b97ee8)) * chore(release): 1.8.28 ## [1.8.28](v1.8.27...v1.8.28) (2022-09-02) ### Bug Fixes * **deps:** update dependency fast-blob-stream to ^1.1.1 ([a441dea](a441dea)) * **deps:** update dependency join-async-iterator to ^1.1.1 ([09b9958](09b9958)) * fix(deps): update dependency create-torrent to ^5.0.6 * chore(release): 1.8.29 ## [1.8.29](v1.8.28...v1.8.29) (2022-09-03) ### Bug Fixes * **deps:** update dependency create-torrent to ^5.0.6 ([03a0f50](03a0f50)) * fix: return duplicate torrent on Webtorrent.add() (#2372) * Update index.js if the there is a duplicate torrent, return the torrent * no more emitting 'torrent' for duplicate torrents * chore(release): 1.8.30 ## [1.8.30](v1.8.29...v1.8.30) (2022-09-12) ### Bug Fixes * return duplicate torrent on Webtorrent.add() ([#2372](#2372)) ([05d27bf](05d27bf)) * chore(deps): update dependency tape to v5.6.1 * chore(deps): update actions/stale action to v6 (#2378) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Change link of repojacking vulnerable link (#2382) * fix(deps): update dependency bittorrent-dht to ^10.0.6 (#2384) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(release): 1.8.31 ## [1.8.31](v1.8.30...v1.8.31) (2022-10-08) ### Bug Fixes * **deps:** update dependency bittorrent-dht to ^10.0.6 ([#2384](#2384)) ([34089f8](34089f8)) * fix(deps): update dependency torrent-discovery to ^9.4.14 * chore(release): 1.8.32 ## [1.8.32](v1.8.31...v1.8.32) (2022-10-09) ### Bug Fixes * **deps:** update dependency torrent-discovery to ^9.4.14 ([8fadd4f](8fadd4f)) * chore(deps): update dependency @webtorrent/semantic-release-config to v1.0.8 * feat: add chitchatter link (#2388) * chore: require Node.js 14 * fix(deps): update dependency fs-chunk-store to v3 (#2380) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(release): 1.9.0 # [1.9.0](v1.8.32...v1.9.0) (2022-10-28) ### Bug Fixes * **deps:** update dependency fs-chunk-store to v3 ([#2380](#2380)) ([9abd966](9abd966)) ### Features * add chitchatter link ([#2388](#2388)) ([7ef22f7](7ef22f7)) * fix(deps): update dependency streamx to ^2.12.5 (#2366) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(release): 1.9.1 ## [1.9.1](v1.9.0...v1.9.1) (2022-10-28) ### Bug Fixes * **deps:** update dependency streamx to ^2.12.5 ([#2366](#2366)) ([457a2d3](457a2d3)) * chore: fix test typo * ci: add node 18 Signed-off-by: Tobias Speicher <rootcommander@gmail.com> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> Co-authored-by: Diego Rodríguez Baquero <diego@mothership.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Artak Safaryan <32634773+holoyan@users.noreply.github.com> Co-authored-by: Drakonkat <adamo.mazzocchetti@gmail.com> Co-authored-by: Mauro Mazzocchetti <m.mazzocchetti@tech4care.it> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: CommanderRoot <CommanderRoot@users.noreply.github.com> Co-authored-by: Justin Lewis Salmon <jlsalmon@users.noreply.github.com> Co-authored-by: Diego Rodríguez Baquero <github@diegorbaquero.com> Co-authored-by: Alex <alxmorais8@msn.com> Co-authored-by: Diego Rodriguez Baquero <diego@protocol.ai> Co-authored-by: Sukka <isukkaw@gmail.com> Co-authored-by: Nipuna Weerasekara <w.nipuna@gmail.com> Co-authored-by: Feross Aboukhadijeh <feross@feross.org> Co-authored-by: tedd pasta <37799569+resession@users.noreply.github.com> Co-authored-by: Ilaygoldman <29836366+Ilaygoldman@users.noreply.github.com> Co-authored-by: Jeremy Kahn <jeremyckahn@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.
Which issue (if any) does this pull request address?
Is there anything you'd like reviewers to focus on?