Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify set_size on macOS #393

Merged
merged 1 commit into from
Jun 20, 2020
Merged

Conversation

rajivshah3
Copy link
Contributor

This PR simplifies set_size. Creating a struct called size and setting width and height properties seems a bit unnecessary when the CGSizeMake API does the same thing:

image

image

@zserge zserge merged commit 23336a0 into webview:master Jun 20, 2020
@rajivshah3 rajivshah3 deleted the refactor/set-size branch June 20, 2020 15:32
@SteffenL SteffenL added this to the v0.10.0 milestone Sep 1, 2023
@SteffenL SteffenL added the type: improvement Pull request is an improvement of an existing feature label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement Pull request is an improvement of an existing feature
Development

Successfully merging this pull request may close these issues.

3 participants