Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Error System #52

Open
WYVERN2742 opened this issue Oct 24, 2022 · 2 comments
Open

Better Error System #52

WYVERN2742 opened this issue Oct 24, 2022 · 2 comments
Labels
🐛 Bug Something isn't working 🧹 Housekeeping Improvements to code quality UI User Interface UX User Experience
Milestone
🏗 v1.0.0

Comments

@WYVERN2742
Copy link
Contributor

Right now, the error system is a mess and does not cover all scenarios.

The error system should be redone alongside the validation system in order to clearly indicate to the user what has gone wrong. Validation should preemptively prevent any user-side inputs that will cause errors to the backend.

Some examples:

  • Currently, broken configuration files do not show any indicator during import
  • When the backend server is down, errors flood the UI since each component fails to transmit
  • Too fine-grained response from the server doesn't need to say exactly what paramater caused an error
@WYVERN2742 WYVERN2742 added 🐛 Bug Something isn't working UX User Experience UI User Interface labels Oct 24, 2022
@WYVERN2742 WYVERN2742 added this to the 🏗 v1.0.0 milestone Oct 24, 2022
@WYVERN2742 WYVERN2742 added the 🧹 Housekeeping Improvements to code quality label Nov 17, 2022
WYVERN2742 added a commit that referenced this issue May 20, 2024
@WYVERN2742
feat: ✨ Add support for focal spot size
43bbcda 
- Add support for focal spot in beam parameters
- Change typing of PipeConnection to Connection
   - This fixes a compilation issue on Linux
- Replace gvxr.computeProjectionSet() with a loop
   - This is due to a breaking change with latest master of gvxr
- Add tqdm progress bar to reconstruction
   - This may be temporary, should be investigated with Better Error System #52
@WYVERN2742 WYVERN2742 mentioned this issue May 20, 2024
Merged
WYVERN2742 added a commit that referenced this issue May 20, 2024
@WYVERN2742
feat: ✨ Add support for focal spot size (#5) (#65)
68ec176 
feat: ✨ Add support for focal spot size

- Add support for focal spot in beam parameters
- Change typing of PipeConnection to Connection
   - This fixes a compilation issue on Linux
- Replace gvxr.computeProjectionSet() with a loop
   - This is due to a breaking change with latest master of gvxr
- Add tqdm progress bar to reconstruction
   - This may be temporary, should be investigated with Better Error System #52
@WYVERN2742
Copy link
Contributor Author

"PUT /material/set HTTP/1.1" 200

Has no failure case, issues saving new materials are not propagated to frontend

WYVERN2742 added a commit that referenced this issue Aug 17, 2024
@WYVERN2742
fix: 🐛 Better console logging
0059f9e 
This works towards #52

- Standardized logging format for all submodules
    - All endpoints, session manager, simulator monitoring
- Save GVXR logs to seperate file
- Redone logging for all modules
- Added quick validation for adding samples
- Kill simulator child when strange behavior is detected.
    - This is currently causing issues into restoring into a good state. More work is required for #81
@WYVERN2742 WYVERN2742 mentioned this issue Aug 17, 2024
Merged
WYVERN2742 added a commit that referenced this issue Aug 17, 2024
@WYVERN2742
fix: 🐛 Better console logging (#82)
c8afd41 
This works towards #52

- Standardized logging format for all submodules
    - All endpoints, session manager, simulator monitoring
- Save GVXR logs to seperate file
- Redone logging for all modules
- Added quick validation for adding samples
- Kill simulator child when strange behavior is detected.
    - This is currently causing issues into restoring into a good state. More work is required for #81
@WYVERN2742
Copy link
Contributor Author

Much work done towards this on the backend side with #82

Still require work on the frontend, and error recovery (such as #81)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug Something isn't working 🧹 Housekeeping Improvements to code quality UI User Interface UX User Experience
Projects
WebCT
Status: 🏗 In progress
Milestone
🏗 v1.0.0
Development

No branches or pull requests
1 participant
@WYVERN2742