Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ding-dong example requires uos protocol; gcloud libatk-bridge2.0 #295

Merged
merged 5 commits into from
Jul 14, 2023

Conversation

vyvy3n
Copy link
Contributor

@vyvy3n vyvy3n commented Jul 6, 2023

I'm submitting a...

[x] Bug Fix
[ ] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added

Description

Issues: Minor bug fix to help the beginners to use the repo.

  1. ding-dong-bot.ts uos protocol
  2. examples/tutorials/google-cloud-shell-tutorial.md: add required system dependency: libatk-bridge2.0

Notes: Thanks @choogoo for explaining uos protocol

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@CLAassistant
Copy link

CLAassistant commented Jul 6, 2023

CLA assistant check
All committers have signed the CLA.

@vyvy3n vyvy3n changed the title Fix: ding-dong example requires uos protocol Fix: ding-dong example requires uos protocol; gcloud libatk-bridge2.0 Jul 6, 2023
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huan huan merged commit 5f86ab2 into wechaty:main Jul 14, 2023
0 of 3 checks passed
@huan
Copy link
Member

huan commented Jul 14, 2023

Thank you very much for your contribution!

You are welcome to join Wechaty Contributor Program

1. Join Wechaty Organization

You've invited Tianwei Yue to Wechaty! They'll be receiving an email shortly. They can also visit https://github.com/wechaty to accept the invitation.

I have invited you to join our Wechaty GitHub Organization, please accept it by following the above message. (See also: wechaty/PMC#16)

2. Update Your Wechaty Contributor Profile

  1. Please open Contributor Hall of Fame and add yourself to the end of the list, so that other contributors will know you better!
  2. Please add yourself to our Website Contributors by creating a PR and refer to this PR link as well.

3. Join The Contributor Only WeChat Room

We also have a WeChat room for contributors only which can discuss Wechaty at a deeper level, you are welcome to join and if you are interested.

Please add @lijiarui wechat: ruirui_0914 and send her this pr link. She will invite you into Wechaty Contributor Room

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants