Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base64 support filebox related to issue #83 #84

Merged
merged 2 commits into from
Dec 17, 2020

Conversation

Charles-Wu-Chen
Copy link

Related to issue #83

To add base64 type filebox, as Donut puppet generates filebox in base64 type

@Charles-Wu-Chen Charles-Wu-Chen requested a review from a team as a code owner December 14, 2020 10:03
@Charles-Wu-Chen
Copy link
Author

@diaozxin007 for your review please

Copy link
Collaborator

@diaozxin007 diaozxin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diaozxin007 diaozxin007 merged commit 25a4f07 into wechaty:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants