wechaty dependency modules deep cleaning

[suntong]

1. Versions

• What is your wechaty version?
  Answer: 0.30.23

• What is your wechaty-puppet-XXX（padchat/puppeteer/） version?
  Answer: wechaty-puppet-puppeteer@0.18.3 / wechaty-puppet-mock@0.16.1

• What is your node version? (run node --version)
  Answer: v12.9.1

• What os are you using
  Answer: Ubuntu 18.04.2 LTS

2. Describe the issue

Following up from wechaty/puppet-mock#33,

rm -rf package-lock.json
rm -rf node_modules
npm install

# However, the problem is:

$ npm list > /dev/null
npm ERR! peer dep missing: eslint@^5.0.0, required by @typescript-eslint/eslint-plugin@1.13.0
npm ERR! peer dep missing: eslint@^5.0.0, required by @typescript-eslint/eslint-plugin-tslint@1.13.0
npm ERR! peer dep missing: eslint@^5.0.0, required by @typescript-eslint/parser@1.13.0

I.e.,

• eslint is missing, but is it necessary as a local package? I have eslint installed as global package already.
• if it is, then its version is way old.

Moreover, npm-check reports that,

$ npm-check
@chatie/eslint-config      ð  NOTUSED?  Still using @chatie/eslint-config?
                                        Depcheck did not find code similar to require('@chatie/eslint-config') or import from '@chatie/eslint-config'.
                                        Check your code before removing as depcheck isn't able to foresee all ways dependencies can be used.
                                        Use --skip-unused to skip this check.
                                        To remove this package: npm uninstall --save-dev @chatie/eslint-config

@chatie/git-scripts        ð  NOTUSED?  Still using @chatie/git-scripts?
                                        Depcheck did not find code similar to require('@chatie/git-scripts') or import from '@chatie/git-scripts'.
                                        Check your code before removing as depcheck isn't able to foresee all ways dependencies can be used.
                                        Use --skip-unused to skip this check.
                                        To remove this package: npm uninstall --save-dev @chatie/git-scripts

@chatie/tsconfig           ð  NOTUSED?  Still using @chatie/tsconfig?
                                        Depcheck did not find code similar to require('@chatie/tsconfig') or import from '@chatie/tsconfig'.
                                        Check your code before removing as depcheck isn't able to foresee all ways dependencies can be used.
                                        Use --skip-unused to skip this check.
                                        To remove this package: npm uninstall --save-dev @chatie/tsconfig

So now the question is, are the following modules really necessary for wechaty?

@chatie/eslint-config
@chatie/git-scripts
@chatie/tsconfig

6. Full Output Logs

Show Logs

$ npm list eslint 
wechaty-getting-started@0.1.19
+-- @chatie/eslint-config@0.8.1
| `-- UNMET PEER DEPENDENCY eslint@6.8.0 
`-- eslint@6.8.0 

npm ERR! peer dep missing: eslint@^5.0.0, required by @typescript-eslint/eslint-plugin@1.13.0
npm ERR! peer dep missing: eslint@^5.0.0, required by @typescript-eslint/eslint-plugin-tslint@1.13.0
npm ERR! peer dep missing: eslint@^5.0.0, required by @typescript-eslint/parser@1.13.0

[bug]

[huan]

So now the question is, are the following modules really necessary for wechaty?

Short answer: NO.

Long version:

1. For development: Yes, they are necessary.
2. For production: No, they aren't.

You can run npm install --production to do not install all of them without any problem for running wechaty as a required module. (And you should do this on your server when you deploy your system)

[suntong]

Oh, thanks for the swift reply.

If using npm install --production, is there any way to silence the npm outdated & npm list complains?

[huan]

- npm list > /dev/null
+ npm list > /dev/null 2>&1

[suntong]

OK then, as long as I know that they are not needed, I'm OK with the npm list complains then, as it is the npm design issue, not wechaty's. Thanks for your help @huan.

[huan]

Yes, everything is good, you are safe and those warning messages can be ignored without any problem.

However, I have just cleaned some modules. Now the npm outdated output is cleaner:

$npm outdated
Package                Current  Wanted  Latest  Location
@chatie/eslint-config    0.9.1   0.9.1   0.8.1  wechaty
wechaty-puppet-hostie   0.3.19  0.3.19   0.3.5  wechaty
wechaty-puppet-mock     0.17.5  0.17.5  0.16.1  wechaty

And the npm list output:

$ npm list > /dev/null
npm ERR! peer dep missing: tslint@^5.0.0, required by @typescript-eslint/eslint-plugin-tslint@2.20.0
npm ERR! peer dep missing: tslint@^5.0.0, required by tslint-eslint-rules@5.4.0
npm ERR! extraneous: path-key@3.1.1 /home/huan/chatie/wechaty/node_modules/cross-env/node_modules/path-key
npm ERR! extraneous: shebang-command@2.0.0 /home/huan/chatie/wechaty/node_modules/cross-env/node_modules/shebang-command
npm ERR! extraneous: which@2.0.2 /home/huan/chatie/wechaty/node_modules/cross-env/node_modules/which
npm ERR! extraneous: markdown-it@10.0.0 /home/huan/chatie/wechaty/node_modules/markdownlint-cli/node_modules/markdown-it
npm ERR! missing: markdown-it@10.0.0, required by markdownlint@0.19.0
npm ERR! extraneous: diff@3.5.0 /home/huan/chatie/wechaty/node_modules/tstest/node_modules/diff
npm ERR! missing: diff@^3.5.0, required by sinon@7.5.0

With Wechaty@0.31.22:

$ npm version
{ wechaty: '0.31.22',
  npm: '6.11.1',
  ares: '1.15.0',
  cldr: '34.0',
  http_parser: '2.8.0',
  icu: '63.2',
  modules: '64',
  napi: '3',
  nghttp2: '1.37.0',
  node: '10.15.2',
  openssl: '1.1.1c',
  tz: '2019a',
  unicode: '11.0',
  uv: '1.30.1',
  v8: '6.8.275.32-node.12',
  zlib: '1.2.11' }