fix: Message.mention()

[jzj1993]

I'm submitting a...

[ ] Bug Fix

Checklist

• Commit Messages follow the Conventional Commits pattern
  • A feature commit message is prefixed "feat:"
  • A bugfix commit message is prefixed "fix:"
• Tests for the changes have been added

Description

Fix message.mention() bug on PC/Mac.

AT_SEPERATOR should be "\u0020" if message is sent from PC/Mac, and "\u2005" from mobile:

This bug is already mentioned here:

• Bug on message.mention() method when messages sent by PC/Mac wechat #1511
• mentionSelf() and mention() enhancement #1569

Does this PR introduce a breaking change?

[ ] No

[huan]

@windmemory Could you please help @jzj1993 to review this PR?

If you could, then I hope to merge this one with yours at the same time.

Thank you very much.

[windmemory]

This build is broken by typescript upgrade I believe, it now will parse the fake function and check the type on it. In my PR, I fixed that issue, so I would suggest to merge my change first, then rebase this change onto master to see whether the build get fixed.

[windmemory]

Besides that, you forgot to modify the logic in room.ts, which also support the say function, please add that change as well. Thanks :)

[windmemory]

After a close review on the logic, I think the change looks good. The FOUR_PRE_EM_SPACE is used in room.say(), but not in message.say(), it confused me, but not related to this change.

Approved.

[huan]

@windmemory Thanks for the review and approvement!

[huan]

@jzj1993 Thank you very much for the contribution!

If you like to talk with other contributors, please contact @lijiarui to add you to the contributor team group in wechat! :)

[lijiarui]

@jzj1993 Could you add my wechat: 13141321843, Thanks！

[huan]

@lijiarui Thanks for following up.

@jzj1993 I have sent you an invitation for joining the Chatie Org on Github, please check your email or just follow the instruction below:

You've invited 江子健 to Chatie! They'll be receiving an email shortly. They can also visit https://github.com/Chatie to accept the invitation.