Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AvatarBrowserUploaderSaveService breaks on non-english locale #57

Closed
kraftner opened this issue Nov 21, 2016 · 2 comments
Closed

AvatarBrowserUploaderSaveService breaks on non-english locale #57

kraftner opened this issue Nov 21, 2016 · 2 comments
Assignees
@kraftner
Labels
bug
Milestone
1.0.0

Comments

@kraftner
Copy link
Member

This check for Upload checks for a string that gets translated. So in German this ends up as Hochladen and always fails.
@kraftner kraftner added the bug label Nov 21, 2016
@kraftner
Copy link
Member Author

This of course only applies after #32 is merged because otherwise it isn't working anyway.

kraftner added a commit to kraftner/wcm-avatar that referenced this issue Nov 21, 2016
@kraftner
Fix: Translate submit button string (same issue as in wecodemore#57)
efdedfb
kraftner added a commit to kraftner/wcm-avatar that referenced this issue Nov 21, 2016
@kraftner
Fix: Translate submit button string, fixes wecodemore#57
6af5186
@kraftner kraftner mentioned this issue Nov 21, 2016
Merged
@kraftner kraftner self-assigned this Nov 21, 2016
@kraftner kraftner added this to the 1.0.0 milestone Nov 21, 2016
@kraftner
Copy link
Member Author

Fixed by #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kraftner kraftner

Labels
bug
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@franz-josef-kaiser @kraftner