Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

${current_buffer} in buflist.look.display_conditions has no effect #1393

Closed
oakkitten opened this issue Aug 16, 2019 · 2 comments
Closed

${current_buffer} in buflist.look.display_conditions has no effect #1393

oakkitten opened this issue Aug 16, 2019 · 2 comments
Assignees
Labels
bug Unexpected problem or unintended behavior
Milestone

Comments

@oakkitten
Copy link

Bug summary

${current_buffer} in buflist.look.display_conditions has no effect even though the documentation says it should.

Steps to reproduce

1. run /set buflist.look.display_conditions "${current_buffer}"

Current behavior

Nothing shows in buflist

Expected behavior

Current buffer shows

Suggested solutions

Fix this

Additional information

I think these bug templates are kinda dumb


  • WeeChat version: a906afc3d7281683799f8b32ca5d5bc06df75f8f
  • OS, distribution and version: Raspbian GNU/Linux 9 (stretch) Linux 4.19.42-v7+ armv7l GNU/Linux
@flashcode flashcode added the bug Unexpected problem or unintended behavior label Aug 17, 2019
@flashcode flashcode self-assigned this Aug 17, 2019
@flashcode
Copy link
Member

flashcode commented Aug 17, 2019

In fact, the doc is wrong. The conditions are evaluated without extra variables, because these variables are defined after, only if conditions are met, for speed reasons (computing all variables has a cost, and if conditions is false, it's better to not set them).
So I'll fix the /help buflist and mention the allowed variables in /help buflist.look.display_conditions.

@flashcode flashcode added this to the 2.6 milestone Aug 17, 2019
@flashcode flashcode added doc Project documentation and removed doc Project documentation labels Aug 17, 2019
@flashcode
Copy link
Member

Reopening the issue, I'll finally use all the variables in the option buflist.look.display_conditions. This will just be a bit slower in case a buffer is not defined, but it should rarely happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants