Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: add fix for ncurses with separate tinfo #1090

Closed
wants to merge 3 commits into from
Closed

core: add fix for ncurses with separate tinfo #1090

wants to merge 3 commits into from

Conversation

alyptik
Copy link
Contributor

@alyptik alyptik commented Oct 24, 2017

use pkg-config when linking ncurses if it is available to fix the unresolved issue in PR #468

relevant bug reports: #41245 #507170 #56000

@flashcode flashcode added the bug Unexpected problem or unintended behavior label Oct 24, 2017
@flashcode
Copy link
Member

flashcode commented Oct 26, 2017 •
edited
Loading

I tested with this fix which is adding -ltinfo during linking, and this breaks the display in WeeChat: the vertical lines and UTF-8 chars are rendered with letters, and accents are displayed as garbage, for example in French: relayM- M-CM-) sur le port 9000, instead of: relay : écoute sur le port 9000.
I'm running WeeChat inside screen on Debian Sid. My locale is fr_FR.UTF-8. Ncurses version: 6.0+20170902-1

What could be the cause of that?

@flashcode flashcode self-assigned this Oct 26, 2017
@flashcode flashcode added the waiting info Waiting for info from author of issue label Oct 26, 2017
@flashcode flashcode closed this in 7a17941 Oct 26, 2017
@flashcode flashcode removed the waiting info Waiting for info from author of issue label Oct 26, 2017
@flashcode flashcode added this to the 2.0 milestone Oct 26, 2017
@flashcode flashcode mentioned this pull request Oct 26, 2017
Closed
gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request Feb 17, 2019
@gyakovlev
net-irc/weechat: bump to 2.4, ebuild improvements
9b66b31 
Bump eapi to 7
drop tinfo patch: weechat/weechat#1090
use default makefile generator (ninja for EAPI7) #558578
gnome2_icon_cache_update -> xdg_icon_cache_update
add manpage building and useflag
removed unneeded source-highlight dep (now uses prettify)
add ruby 2.6
sort mycmakeargs

Package-Manager: Portage-2.3.60, Repoman-2.3.12
Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@flashcode flashcode

Labels
bug Unexpected problem or unintended behavior
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alyptik @flashcode