Directory creation #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added in more contol options including higer level all_data_options (allowing for a pass down and tie-together of options across data sets)
commenting out some uses of old functions in stuff i haven't cleaned yet (metadata and portalcast)
to accommodate hardcoded portalr functions in the context of most-recent-newmoons missing from the moons data table
now have a hierarchy captured in the pacakge_outline file this allows a single creation of the options at the highest level that ties things together as well as creation of only the options needed at each sub level within the directory
included in the options set up, etc beginnings of getting the model generation to work nicely
…he all options list
…the master full forecasting capabilities hindcasting is not setup in portalcast yet, but that will be done in a new branch
This was referenced Jun 22, 2018
Closed
PrayasJ
pushed a commit
to PrayasJ/portalcasting
that referenced
this pull request
Aug 24, 2022
Directory creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tons of changes in here, bringing the whole codebase under a singular options list hierarchy (documented in
all_options) that allows for nearly complete user-control (i.e. most hard-wired things have been un-hard-wired), while still needing 0 input arguments altered at the front-end for standard usage, and a facility to tie all of the options components together (so a change in one option cascades accordingly)....which has been worked towards here, but will need continued work for sure into the future.a lot of the code has been broken out into more specific scripts and functions, with the goal of having more, simpler-focused functions (as opposed to fewer, larger-scoped functions), which will facilitate better testing and control of changes.
sets up a beginning simple framework to address #6 in the
package_outline.txtfile. it's a simple textual approach, but it seems to be pretty good for now. will need to continue to add to it.addresses #5:
PortalDatais now included in the subdirectories and now thefill_PortalDatafunction (withinfill_dir) explicitly locates the data in that folderaddresses #1:
transfer_historical_covariate_forecastsmoves the data over from the package folder to the project directory, and is included inprep_covariates. Once the data file is housed on the github repo, we'll need to swap out where the file is coming from