Add a small repl #38
Open
Add a small repl #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd be interested in whether there's a specific reason for the way the arguments are currently. bb3a343 is a bit of a horrible cludge, and if there's a nicer way of doing this, I'd be really curious. |
|
Thanks for the PR. This looks pretty cool. The current argument ordering is based on grep/ripgrep defaults. Originally weggli also supported an empty path argument to search the current directory but I already removed that feature. Still, I would like to avoid the breaking change in bb3a343. Let me think about the best way to implement the argument parsing for a bit and I'll get back to you. |
While this does break existing workflows, there are two main arguments for doing this: 1. it is a more a common workflow, that the path is kept constant while the query is iterated upon. Having the query as the last positional argument makes it easier to go up in history and edit the query. 2. it sets things up to for other interactive input methods for queries.
|
Rebased this on the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a small REPL shell using rustyline.
It parses all the sources into a tree once, displaying a status bar as it goes along:
Then you can query from a REPL, and it's actually a bit more responsive. The repl does minimal checks like bracket matching:
Questions: