Skip to content

Commit

Permalink
Remove CMake related files from ZIP
Browse files Browse the repository at this point in the history
  • Loading branch information
noloader committed Sep 15, 2016
1 parent f2e5149 commit e1fa9b2
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions Filelist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -310,8 +310,6 @@ License.txt
Readme.txt
Install.txt
Filelist.txt
CMakeLists.txt
cryptopp-config.cmake
TestData/3desval.dat
TestData/3wayval.dat
TestData/camellia.dat
Expand Down

2 comments on commit e1fa9b2

@noloader
Copy link
Collaborator Author

@noloader noloader commented on e1fa9b2 Sep 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Cmake related files will no longer be distributed in the ZIP. The CMake related files will be available in Master.

The decision could change in the future if someone steps up to maintain it. CMake has too many open issues, and neither UB and JW have the time or expertise to maintain it.


Here's more of the back story... CMake does not build the library to our specs. We know the specs, but we don't know how to instruct CMake. Sometimes its easy to learn the CMake procedure, other times its not. For example, it was relatively pain free to instruct CMake to stop hiding its output so we could see the build. The same cannot be said about instructing CMake to use CXXFLAGS when linking.

When JW runs into issues, he emails the three folks who wanted CMake and supplied the initial patches. The CMake folks no longer respond to emails. Additionally, Stack Overflow is not producing the desired level of support from those who know the tool. CMake is mostly unsupported now.

Recently, we discovered CMake does not build the library or test programs with symbols. Here's JW trying to debug an issue under Solaris with DBX. Its a nearly useless trace. We specifically instruct users to build with symbols, and we will not promote tools that can't comply with basic policies, and makes it difficult to do so.

(dbx) where
=>[1] CryptoPP::Baseline_Multiply2(0x23e64d0, 0x240b6f0, 0x240b7b0, 0x240b7b0, 0xa, 0x23dcbc8), at 0x182fac7 
  [2] CryptoPP::RecursiveMultiply(0x0, 0x0, 0x0, 0x0, 0x0, 0x0), at 0x1846067 
  [3] CryptoPP::AsymmetricMultiply(0x0, 0x0, 0x0, 0x0, 0x0, 0x0), at 0x18473a0 
  [4] CryptoPP::PositiveMultiply(0x0, 0x0, 0x0, 0x0, 0x0, 0x0), at 0x1855167 
  [5] CryptoPP::Multiply(0x0, 0x0, 0x0, 0x0, 0x0, 0x0), at 0x18551da 
  [6] CryptoPP::Integer::Times(0x0, 0x0, 0x0, 0x0, 0x0, 0x0), at 0x18552c3 
  [7] CryptoPP::StringToInteger<char>(0x0, 0x0, 0x0, 0x0, 0x0, 0x0), at 0x1862e12 
  [8] CryptoPP::Integer::Integer(0x0, 0x0, 0x0, 0x0, 0x0, 0x0), at 0x184c9f5 
  [9] ValidateBBS(0x0, 0x0, 0x0, 0x0, 0x0, 0x0), at 0x11b6dcb 
  [10] ValidateAll(0x0, 0x0, 0x0, 0x0, 0x0, 0x0), at 0x108bf07 
  [11] Validate(0x0, 0x0, 0x0, 0x0, 0x0, 0x0), at 0xcdb7fe 
  [12] main(0x0, 0x0, 0x0, 0x0, 0x0, 0x0), at 0xca2e7a 

Finally, CMake contributed to Issue 277: Cut-over to CRYPTOPP_ASSERT due to CVE-2016-7420. The other big offender is Autotools.

@noloader
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.