Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
I believe this is the last group from #889
- Loading branch information
Showing
2 changed files
with
4 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c0c2c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit breaks VS 2019 compilation when using the provided
cryptlib.vcxproj
.f2c0c2c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @irwir .
I can't duplicate it locally using VS2015 or VS2017 using the Nmake file or MSbuild. I don't have VS2019 to test with.
Can you provide more details?
Ping @MarcelRaad .
f2c0c2c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both VS 2017 and VS2019 fail, no VS2015 at hand; Community edition will do.
How to reproduce.
Get an archive from Github, unpack, start IDE, open the project or solution, right click on the library project and select
Build
.f2c0c2c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@irwir,
I was able to duplicate on a VS2013 machine. The compile errors should be fixed now. Sorry about that.
In the future please make a pull request. It will avoid the lag time when we have trouble duplicating the issue.