-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipe to not install test program and test data #653
Comments
@alonbl , Yeah, so I know the problem you are having in the bigger picture. László Böszörményi (@gcsideal) solved it in Debian with Autotools by building two instances of The first instance is called In the bigger picture the problem are files in the Here is what the code looks like. It is an example of the problem (from
The problem is, I'm thinking we may need to revisit this. Instead of making folks decide on a value for I think @mouse07410 was a proponent of the intelligent search way back when. Ping @mouse07410 and @MarcelRaad for feedback. |
thanks! |
As Jeffrey (@noloader) noted, Debian compiles cryptest.exe as-is only the name is changed to cryptestcwd.exe . It can be used for testing before the actual installation. |
Lol... I've wondered that myself. In the years (decades?) I have been following the library I don't recall anyone using it like, say, @alonbl, @gcsideal, @MarcelRaad, @mouse07410, Is anyone aware of a standard target that installs the library only, and not the library and test program? I did not see one listed at GNU Coding Standards | Standard Targets. In the absence of a standard target, how does |
The build system of your library is non-standard, proprietary and hard to maintain. The absent of standard build system that GNU is using (Autotools) or even cmake is obvious. This is why I was very much surprised that you chose GNU as a reference for that question. The best practice would have a configure script in which one can specify how build system should behave, including, and not limited to, installing test programs, also obviously toolchain setting (CXX, AR...), location of directories (bindir, libdir) and features (enable-asm). The build sequence should be as simple as:
You can have custom configure script if you hate autotools, but the logic behind the build system is that you state what you need, then build (make) respect that. Let's take the simple example of the pkg-config target you recently added after long time that it was asked... now it is yet another target of Makefile, I totally missed that since there is no way to extract the options using |
Deja-vu #327 :) |
Some distros don't want to install cryptest.exe. For folks who don't want to install the test program, they can issue 'make install-lib'. install-lib is a non-standard target, but the GNU Coding Standard does not have a standard target for the task.
Cleared at Commit a07a0e5e5f5f. The old behavior for |
P.S. I support |
Yeah, that is actually on my TODO list. When it arrives it will be written in Python and observe the semantics/behaviors of Autotools. Of all the config scripts I work with on a regular basis, the only one who got it right was Jack Lloyd of Botan (@randombit). Autotools and Cmake have too many problems to use them. Its like throwing away good money on bad. OpenSSL built theirs in Perl but faltered on execution. Not to mention OpenSSL semantics/behaviors change with nearly every version of the library. Using OpenSSL's script is worse than using Autotools or Cmake. The only configuration script I have seen consistently work as expected is Botan's script. |
@noloader, Python has a not too much up-to-date configuration and build tools list: https://wiki.python.org/moin/ConfigurationAndBuildTools |
I hear that Meson[1] is the new trend in python. |
Hi,
Can you please add conditional to the build system to avoid installing the test program and the test data?
The use case should be:
In most cases downstream runs the check during build and these files are not required at root filesystem.
Thanks!
The text was updated successfully, but these errors were encountered: