Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ChaCha AVX2 implementation #735

Closed
noloader opened this issue Nov 8, 2018 · 1 comment
Closed

Add ChaCha AVX2 implementation #735

noloader opened this issue Nov 8, 2018 · 1 comment

Comments

@noloader
Copy link
Collaborator

noloader commented Nov 8, 2018 •
edited
Loading

This ticket will track the cut-in of ChaCha AVX2 implementation. There a little more to this cut-in because AVX2 is new territory. I think we have most of the issues sorted out, including old Linux and Solaris with down-level compilers and linkers.

At the moment AVX2 is failing on one case. The case is VS2017, x64, Release build. AppVeyor result at build 20159656. It may be a similar problem as Issue 649.
noloader referenced this issue Nov 8, 2018
@noloader
Fix Solaris hardware cpas to allow AVX and AVX2
9b31bc1
noloader referenced this issue Nov 8, 2018
@noloader
Fix compile using SunCC 5.9
cc5eb39
noloader added a commit that referenced this issue Nov 8, 2018
@noloader
Add ChaCha AVX2 implementation (GH #735)
d9011f0
noloader added a commit that referenced this issue Nov 9, 2018
@noloader
Fix global optimization bug for ChaCha AVX2 under VS2017 (GH #735)
092309b 
Also see #649. The 649 issue is the one affecting AES. It appears to be the same problem.
@noloader
Copy link
Collaborator Author

Cleared over several commits.

chausner added a commit to chausner/cryptopp that referenced this issue Jul 11, 2022
@chausner
Remove obsolete workarounds for weidai11#649 and weidai11#735
ea8d782
@chausner chausner mentioned this issue Jul 11, 2022
Merged
chausner added a commit to chausner/cryptopp that referenced this issue Jul 29, 2022
@chausner
Disable workarounds for weidai11#649 and weidai11#735 for newer MSVC …
00ea84a 
…versions
noloader added a commit that referenced this issue Aug 25, 2022
@noloader
Disable global optimizations for all versions of VS2017 (GH #649, GH #…
307ada5 
…735, PR #1146)

We started seeing failed self test under VS2017 on AppVeyor. See https://ci.appveyor.com/project/noloader/cryptopp/builds/44570276 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@noloader