Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler warnings on clang++ for archs armv7 and armv7s #777

Closed
jnavarrom opened this issue Jan 9, 2019 · 2 comments
Closed

Compiler warnings on clang++ for archs armv7 and armv7s #777

jnavarrom opened this issue Jan 9, 2019 · 2 comments

Comments

@jnavarrom
Copy link
Contributor

Do you think we can take care of these warning?

clang++ -DNDEBUG -g2 -O3 -fPIC -pipe -Wall -arch armv7 -isysroot "/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS12.1.sdk" -stdlib=libc++ -ffunction-sections -fdata-sections -c scrypt.cpp
scrypt.cpp:167:24: warning: result of comparison of constant 137438953440 with expression of type 'size_t' (aka 'unsigned long') is always false [-Wtautological-constant-out-of-range-compare]
        if (derivedLen > maxLen) {
            ~~~~~~~~~~ ^ ~~~~~~
clang++ -DNDEBUG -g2 -O3 -fPIC -pipe -Wall -miphoneos-version-min=6 -arch armv7s -isysroot "/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS12.1.sdk" -stdlib=libc++ -ffunction-sections -fdata-sections -c scrypt.cpp
scrypt.cpp:167:24: warning: result of comparison of constant 137438953440 with expression of type 'size_t' (aka 'unsigned long') is always false [-Wtautological-constant-out-of-range-compare]
        if (derivedLen > maxLen) {
            ~~~~~~~~~~ ^ ~~~~~~
@noloader
Copy link
Collaborator

Yeah, these are annoying at times. I believe -Wno-tautological-compare does the trick for Clang. I think it got removed a while ago from the flags set by setenv-ios.sh.

Let me add it to the sources.

@noloader
Copy link
Collaborator

Cleared at Commit 22a25c0e84dd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants