-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link-library variable to Makefiles #866
Comments
noloader
added a commit
that referenced
this issue
Jul 21, 2019
This should help distros and Crypto++ test scripts
noloader
added a commit
that referenced
this issue
Jul 21, 2019
noloader
referenced
this issue
Jul 21, 2019
noloader
added a commit
that referenced
this issue
Jul 21, 2019
The change was added at Commit 52ad132134c1 (and friends). The change allows:
The user is still responsible to add a path to
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the recipe to build
cryptest.exe
hard-codeslibcryptopp.a
. FromGNUmakefile
:Using
libcryptopp.a
is a good engineering decision because it sidesteps path problems that plague Unix and Linux.However, there are two gaps. First, distros usually patch to use the shared object. Second,
cryptest.sh
(and some other scripts) test shared object linking, and they require makefile hacks. For example, we make a copy of the makefile, run sed over it, and then use the new makefile for testing.We can make it easier to swap-in the shared object by introducing a makefile variable:
This will track the changes to add the variable
LINK_LIBRARY
.The text was updated successfully, but these errors were encountered: