-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VectorSink #334
Add VectorSink #334
Conversation
Thanks @orangefour. Hat's off for the test cases :) Would you be able to whip up a |
I tried to implement |
Status? |
I have fixed conflicts, it would be nice to see this pull request accepted. |
It's been almost a year. @orangefour would you care to rebase to the current master? @noloader if this PR is rebased, would you accept it for merge? |
I was hoping for both |
I'm waiting for the author to resolve conflicts first. And it would be nice if the author could commit to writing VectorSource as well. But I think it's ok if we merge Sink first, as long as Source would follow. |
014f5b3
to
9b81a54
Compare
I will try to find time for VectorSource, but please merge VectorSink first. I fixed conflicts and cleaned up everything to a single commit |
@orangefour I'm merging this PR, thanks for contributing. I do hope that you do find time for VectorSource, as it's been the tradition of this library to provide both Source and Sink. |
✅
T::traits_type::char_type char_type
→T::value_type
(all STL containers have this)✅
sizeof(output[0])
→sizeof(value_type)
(works with any containers, not just random access)✅
append
→insert
(more universal)✅ simple unit test
🚀 VectorSink typedef