Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VectorSink #334

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Conversation

orangefour
Copy link
Contributor

T::traits_type::char_type char_typeT::value_type (all STL containers have this)
sizeof(output[0])sizeof(value_type) (works with any containers, not just random access)
appendinsert (more universal)
✅ simple unit test

🚀 VectorSink typedef

@noloader
Copy link
Collaborator

noloader commented Nov 9, 2016

Thanks @orangefour. Hat's off for the test cases :)

Would you be able to whip up a VectorSource to accompany the VectorSink?

@orangefour
Copy link
Contributor Author

I tried to implement VectorSource in a nice way but it needs a little bit more time. It would be nice to see VectorSink accepted first 😉

@anonimal
Copy link
Contributor

Status?

@orangefour
Copy link
Contributor Author

I have fixed conflicts, it would be nice to see this pull request accepted.

@mouse07410
Copy link
Collaborator

It's been almost a year. @orangefour would you care to rebase to the current master? @noloader if this PR is rebased, would you accept it for merge?

@noloader
Copy link
Collaborator

@mouse07410,

I was hoping for both VectorSource and VectorSink. If you like it then feel free to merge it.

@mouse07410
Copy link
Collaborator

I'm waiting for the author to resolve conflicts first.

And it would be nice if the author could commit to writing VectorSource as well. But I think it's ok if we merge Sink first, as long as Source would follow.

@orangefour
Copy link
Contributor Author

I will try to find time for VectorSource, but please merge VectorSink first. I fixed conflicts and cleaned up everything to a single commit

@mouse07410
Copy link
Collaborator

@orangefour I'm merging this PR, thanks for contributing. I do hope that you do find time for VectorSource, as it's been the tradition of this library to provide both Source and Sink.

@mouse07410 mouse07410 merged commit ac43bee into weidai11:master Sep 5, 2018
@orangefour orangefour deleted the feature/vector_sink branch September 6, 2018 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants