Add quotes to milestone in case title contains spaces #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
suggested changes
Nov 19, 2016
| @@ -82,7 +82,7 @@ | |||
|
|
|||
| $client->setUri( | |||
| 'https://api.github.com/search/issues?q=' . urlencode( | |||
| 'milestone:' . $milestonePayload['title'] | |||
| 'milestone:"' . $milestonePayload['title'] . '"' | |||
There was a problem hiding this comment.
Since it was brought to the table - what happens with a " in the milestone?
There was a problem hiding this comment.
Good catch, I've added a straightforward replacement of " to \" which is all that is required. I looked into using addslashes() but it is only " that must be escaped (and escaping others such as \' will result in the search failing.
weierophinney
added a commit
that referenced
this pull request
Feb 22, 2017
Add quotes to milestone in case title contains spaces
weierophinney
added a commit
that referenced
this pull request
Feb 22, 2017
|
Thanks, @asgrim! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered a bug where if the milestone title contains a space (e.g.
1.0.0 (initial release)), the search fails to find any issues. Simple fix here is to always quote themilestone, I see no adverse affects with milestones that do not contain spaces (e.g.1.0.0).