Skip to content

Commit

Permalink
fix: Prevent restart timetick sender creating ut datanode (milvus-io#…
Browse files Browse the repository at this point in the history
…33790)

See also milvus-io#33789

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
  • Loading branch information
congqixia committed Jun 12, 2024
1 parent b39dfc2 commit 9ab3058
Showing 1 changed file with 8 additions and 10 deletions.
18 changes: 8 additions & 10 deletions internal/datanode/event_manager_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,6 @@ func TestWatchChannel(t *testing.T) {
defer etcdCli.Close()
node.SetEtcdClient(etcdCli)
err = node.Init()
assert.NoError(t, err)
err = node.Start()
assert.NoError(t, err)
defer node.Stop()
err = node.Register()
assert.NoError(t, err)

defer cancel()

broker := broker.NewMockBroker(t)
broker.EXPECT().ReportTimeTick(mock.Anything, mock.Anything).Return(nil).Maybe()
Expand All @@ -76,8 +68,14 @@ func TestWatchChannel(t *testing.T) {

node.broker = broker

node.timeTickSender.Stop()
node.timeTickSender = newTimeTickSender(node.broker, 0)
assert.NoError(t, err)
err = node.Start()
assert.NoError(t, err)
defer node.Stop()
err = node.Register()
assert.NoError(t, err)

defer cancel()

t.Run("test watch channel", func(t *testing.T) {
kv := etcdkv.NewEtcdKV(etcdCli, Params.EtcdCfg.MetaRootPath.GetValue())
Expand Down

0 comments on commit 9ab3058

Please sign in to comment.