fix: fix error ignore in compactor (milvus-io#34169)

milvus-io#34170 Signed-off-by: wayblink <anyang.wang@zilliz.com>
weiliu1031 · Jun 26, 2024 · fbe3231 · fbe3231
1 parent a77e295
commit fbe3231
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/internal/datanode/compaction/clustering_compactor.go b/internal/datanode/compaction/clustering_compactor.go
@@ -771,6 +771,7 @@ func (t *clusteringCompactionTask) flushBinlog(ctx context.Context, buffer *Clus
 
 	if err := t.binlogIO.Upload(ctx, kvs); err != nil {
 		log.Warn("compact wrong, failed to upload kvs", zap.Error(err))
+		return err
 	}
 
 	for fID, path := range partialBinlogs {

diff --git a/internal/datanode/compaction/mix_compactor.go b/internal/datanode/compaction/mix_compactor.go
@@ -151,6 +151,7 @@ func (t *mixCompactionTask) merge(
 		allValues, err := t.binlogIO.Download(ctx, paths)
 		if err != nil {
 			log.Warn("compact wrong, fail to download insertLogs", zap.Error(err))
+			return nil, err
 		}
 		downloadTimeCost += time.Since(downloadStart)
 
@@ -205,6 +206,7 @@ func (t *mixCompactionTask) merge(
 				uploadStart := time.Now()
 				if err := t.binlogIO.Upload(ctx, kvs); err != nil {
 					log.Warn("compact wrong, failed to upload kvs", zap.Error(err))
+					return nil, err
 				}
 				uploadTimeCost += time.Since(uploadStart)
 				mergeFieldBinlogs(allBinlogs, partialBinlogs)
@@ -226,6 +228,7 @@ func (t *mixCompactionTask) merge(
 		uploadStart := time.Now()
 		if err := t.binlogIO.Upload(ctx, kvs); err != nil {
 			log.Warn("compact wrong, failed to upload kvs", zap.Error(err))
+			return nil, err
 		}
 		uploadTimeCost += time.Since(uploadStart)