Skip to content

Commit

Permalink
feat!: upgrade storybook v7
Browse files Browse the repository at this point in the history
it also update the builder to vite(rollup-based).
refs: #121
  • Loading branch information
aladdin-add committed Mar 28, 2023
1 parent 23dcdae commit b8cb417
Show file tree
Hide file tree
Showing 6 changed files with 39 additions and 16 deletions.
3 changes: 3 additions & 0 deletions src/getInstallArgs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ export default function getInstallArgs(
cmd: InstallCommand,
packages: string[]
) {
// replace 'package#version' with 'package@version'
packages = packages.map(pkg => pkg.replace(/#/, '@'));

switch (cmd) {
case 'npm':
return ['install', ...packages, '--save-dev'];
Expand Down
19 changes: 11 additions & 8 deletions src/templates/react-with-storybook.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,25 @@ const storybookTemplate: Template = {
dependencies: [
...reactTemplate.dependencies,
'@babel/core',
'@storybook/addon-essentials',
'@storybook/addon-links',
'@storybook/addon-info',
'@storybook/addons',
'@storybook/react',
'storybook#next',
"@storybook/addon-essentials#next",
"@storybook/addon-info#next",
"@storybook/addon-links#next",
"@storybook/addons#next",
"@storybook/react#next",
"@storybook/react-vite#next",
"vite",
'react-is',
'babel-loader',
'@tsconfig/create-react-app',
'@tsconfig/vite-react',
],
name: 'react-with-storybook',
packageJson: {
...reactTemplate.packageJson,
scripts: {
...reactTemplate.packageJson.scripts,
storybook: 'start-storybook -p 6006',
'build-storybook': 'build-storybook',
storybook: 'storybook dev -p 6006',
'build-storybook': 'storybook build',
} as PackageJson['scripts'],
jest: {
testEnvironment: 'jsdom',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@ module.exports = {
addons: ['@storybook/addon-links', '@storybook/addon-essentials'],
// https://storybook.js.org/docs/react/configure/typescript#mainjs-configuration
typescript: {
check: true, // type-check stories during Storybook build
check: true // type-check stories during Storybook build
},

framework: {
name: '@storybook/react-vite',
options: {}
},
docs: {
autodocs: true
}
};
};
5 changes: 0 additions & 5 deletions templates/react-with-storybook/.storybook/preview.js

This file was deleted.

14 changes: 14 additions & 0 deletions templates/react-with-storybook/.storybook/preview.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@

const preview = {
parameters: {
actions: { argTypesRegex: '^on[A-Z].*' },
controls: {
matchers: {
color: /(background|color)$/i,
date: /Date$/,
},
},
},
};

export default preview;
2 changes: 1 addition & 1 deletion templates/react-with-storybook/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
// see https://www.typescriptlang.org/tsconfig to better understand tsconfigs
"extends": "@tsconfig/create-react-app/tsconfig.json",
"extends": "@tsconfig/vite-react/tsconfig.json",
"include": ["src", "types"],
}

0 comments on commit b8cb417

Please sign in to comment.