Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assertions for print_and_capture #31

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Conversation

grewered
Copy link
Collaborator

No description provided.

@sachseka sachseka self-assigned this Mar 18, 2024
Copy link
Collaborator

@sachseka sachseka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if len=1 branch can be merged. everything else LGTM :)

@@ -1,4 +1,6 @@
print_and_capture <- function(x, spaces = 0) {
checkmate::assert_vector(x)
checkmate::assert_numeric(spaces, lower = 0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add len=1 to spaces

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@grewered grewered merged commit 9d16d6a into master Mar 21, 2024
8 checks passed
@grewered grewered deleted the check_print_and_capture branch March 21, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants