Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup class declares member name _current but use current instead #2059

Closed
peishaofeng opened this issue Dec 16, 2018 · 0 comments
Closed

Popup class declares member name _current but use current instead #2059

peishaofeng opened this issue Dec 16, 2018 · 0 comments

Comments

@peishaofeng
Copy link

Wekan version:
from 1.53.0 to latest

Problem description:

  • in client/lib/popup.js, _current is declared as class member but current is actually used.

_current is declared in constructor

    // We only want to display one popup at a time and we keep the view object
    // in this `Popup._current` variable. If there is no popup currently opened
    // the value is `null`.
    this._current = null;

but use current after render embedded template

      if (!self.isOpen()) {
        self.current = Blaze.renderWithData(self.template, () => {
          self._dep.depend();
          return { ...self._getTopStack(), stack: self._stack };
        }, document.body);
xet7 added a commit that referenced this issue Dec 16, 2018
@xet7 xet7 closed this as completed in 3e5ff42 Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant