Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook parameters and response order. #1263

Merged
merged 2 commits into from
Oct 3, 2017
Merged

Conversation

andresmanelli
Copy link
Contributor

@andresmanelli andresmanelli commented Sep 29, 2017

This PR adds to webhook body:

  • Comments IDs and content
  • Cards title
  • Author of the activity

Also:

  • The API response in the case of a comment creation is sent before creating the activity.

This change is Reviewable

@xet7
Copy link
Member

xet7 commented Sep 30, 2017

@andresmanelli

Please add new wiki page for Webhook documentation similar that there is for REST API with examples how your feature works with these new features.

Please also add link to that documentation page to Features page Webhooks

Then I can test this and add this to Wekan.

@andresmanelli
Copy link
Contributor Author

@xet7 I added the requested page and reference in Features page Webhooks.

Could you tell me if there is anything else to add?

@xet7 xet7 merged commit de1ca1d into wekan:devel Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants