Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Nextcloud OAuth2 Hack References Issue #1874 #2897

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

bogie
Copy link
Contributor

@bogie bogie commented Jan 22, 2020

In reference to: #1874 (comment)

I finally got my dev environment running, applied the change and tested:

Login works, however the profile data is not being applied. Is there some sort of additional logic we need to implement in oidc_server.js similarly to ldap auth?


This change is Reviewable

Fixed: OAuth2 authentication via Nextcloud(tested Nextcloud 17.0.2-18.0.0)
Todo: actually use the profile data: Fullname and Email in Profile
@xet7
Copy link
Member

xet7 commented Jan 23, 2020

@xet7 xet7 merged commit 362b643 into wekan:master Jan 23, 2020
@bogie
Copy link
Contributor Author

bogie commented Jan 28, 2020

Hmm, it gets correctly mapped to the serviceData object and also to

options: { profile: profile }

however it does not appear to get applied to the user's profile correctly. I do not understand where OAuth.registerSerivce() gets called from.

Maybe the problem is due to the fact that the admin user was created by oauth2. I will do some more testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants