Clean-up Global Search, Due Cards, and My Cards #3676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code for searching and display
* use onReady and onStop callbacks when subscribing * show an server error message when the server returns an error * call stop() on subscriptions
…running the search on the client side.
DeepCode's analysis on #238b0f found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganize code to remove duplicated code.
Due cards and My Cards now use the global search code to retrieve results. This eliminates duplicated code.
Also some bug fixes and enhancements:
RESULTS_PER_PAGE) to set the default number of results per pageThis change is