-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Copy card" copies now attachments too #4646
Conversation
- for now only the version "original" exists, but as other method already consider that other version's can exist
- renamed copyChecklistToManyCards changed to copyManyCards because the whole card is copied
@mfilser Copying cards that were complex (many checklists and check list items, 100+) has had a lot of problems since we started using Wekan as it was managed client side. We do this often and so we had to compensate for the flakiness by doing things like opening a separate browser window where we would do the copy and just leave that window alone while still working in Wekan in another window. We would have to check the count of the tasks after the copy as if someone forgot to pay close attention you would end up with not all the tasks copied if for instance you navigated to another board before the copy operation finished. If I am understanding some of this code correctly it looks like the whole copy card process is now server side and in our practical testing I have started a card copy, closed wekan, opened it again, navigated to other boards, etc. and while it may take 20+ seconds for the copy of the card to appear (less time than before) it now works reliably without being affected by what we do in the browser. Thank you so much for making this change, this completely eliminates one of the pain points I had to make sure anyone using wekan was aware of and now it just works as expected, albeit still slowly for cards with lots of check list items, but it at least works reliably which is so nice! 🙂🙏 |
What other pain points you have, that you need to make sure anyone using wekan is aware of ? |
In what way it could be improved? Or would it be easier to move cards with keyboard keys, or clicking buttons? |
@xet7 I like the way it works now perfectly well when it works. If you watch the animation you will see that the drop shadow of where the card is supposed to be placed eventually becomes disconnected from where the card is being dragged, you have to keep watching for a while to see it start to happen but it happens which then makes the card go to a place the user doesn't expect as it doesn't go where their mouse is. |
@ChrisMagnuson Yes, the card copy is now done on server side because only the server can access the files at filesystem or mongodb. |
No description provided.