Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

// Silence is golden on wp-content #163

Closed
luisbraga opened this issue May 22, 2015 · 5 comments
Closed

// Silence is golden on wp-content #163

luisbraga opened this issue May 22, 2015 · 5 comments
Assignees

Comments

@luisbraga
Copy link

Shouldn't wp-content folder have this index.php file on push?
Also I've seen some plugins using wp-content for storing files. Should this also be taken into account?

@alessandro-fazzi
Copy link
Member

  1. It should if it exists; otherwise it will delete it remotely
  2. We've encountered such plugins sometimes (wp-super-cache?); personally I disagree with the approach; anyway you should take it into account. Perhaps excluding the transfer of those file within Movefile

Feel free to reopen/continue the discussion as you need.

Cheers

@luisbraga
Copy link
Author

Thank you,

  1. The file exists but it's not being uploaded on push. Same applies for other files created for testing.
  2. Same for existing folders other than the default wordpress install. They don't get uploaded.

This is my exclude config

exclude:
- ".git/"
- ".gitignore"
- ".sass-cache/"
- "bin/"
- "tmp/"
- "Gemfile
"
- "Movefile"
- "wp-config.php"
- "wp-content/.sql"
- ".DS_Store"
- "node_modules/
"
- "bower_components/*"

What could be wrong?

@alessandro-fazzi
Copy link
Member

I'll do a fast check into the code to give you a more precise answer.

@luisbraga
Copy link
Author

Just noticed in the log that "wordmove push --all" adds wp-content/* to the exclude list

▬▬ ✓ Pushing wordpress core ▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬
remote | put_directory: /local/path/ /remote/path/ .git/ .gitignore .sass-cache/ bin/ tmp/* Gemfile* Movefile wp-config.php wp-content/.sql .DS_Store node_modules/ bower_components/* wp-content/*

Is this expected when pushing all ?

@alessandro-fazzi
Copy link
Member

We are discussing a similar thing in #214 @luisbraga

If you're interested your contribute should be helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants