-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerize testing and add Travis config #21
Conversation
d24913e
to
552f6ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fairly strongly opposed to the newtype change, everything else looks ok.
Dockerfile.build
Outdated
@@ -0,0 +1,17 @@ | |||
FROM fedora:26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to use F27 now?
src/BDCS/API/V0.hs
Outdated
@@ -712,7 +712,7 @@ recipesTag repoLock branch recipe_name = liftIO $ RWL.withRead (gitRepoLock repo | |||
|
|||
|
|||
-- | JSON response for /recipes/diff | |||
data RecipesDiffResponse = RecipesDiffResponse { | |||
newtype RecipesDiffResponse = RecipesDiffResponse { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this hlint warning for the returned JSON -- I'd rather keep them all consistent as data. And in the future we may add more fields to them.
@bcl which of the hlint suggestions should I implement? I think all are safe but the data vs newtype ones.